fix: x/gov/client/cli: fix integer overflow in parsing int prompted values #13347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alues Reported by cosmos/gosec in https://github.com/cosmos/cosmos-sdk/security/code-scanning/5730. This change checks for errors from strconv.Atoi in which case we were susceptible to out of range errors, this change also adds tests to prevent regressions. Fixes #13346
odeke-em
force-pushed
the
x-gov-client-cli-fix-overflows-from-code-scanning-5730
branch
from
6a4dede to
5b88eb0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13347 +/- ##
==========================================
- Coverage 54.90% 54.86% -0.05%
==========================================
Files 658 652 -6
Lines 56117 55859 -258
==========================================
- Hits 30810 30645 -165
+ Misses 22818 22733 -85
+ Partials 2489 2481 -8
|
odeke-em
deleted the
x-gov-client-cli-fix-overflows-from-code-scanning-5730
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by cosmos/gosec in https://github.com/cosmos/cosmos-sdk/security/code-scanning/5730. This change checks for errors from strconv.Atoi in which case we were susceptible to out of range errors, this change also adds tests to prevent regressions.
Fixes #13346