Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix IS tests #13420

Merged
merged 9 commits into from
Oct 4, 2022
Merged

fix: fix IS tests #13420

merged 9 commits into from
Oct 4, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Sep 29, 2022

Description

Start fixing the tests of #13122.

  • Migrate tests to mocks
  • Create integrations tests.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt marked this pull request as ready for review October 4, 2022 15:06
@julienrbrt julienrbrt requested a review from a team as a code owner October 4, 2022 15:06
@julienrbrt
Copy link
Member Author

julienrbrt commented Oct 4, 2022

Fixed the unbonding tests. I think the last test (TestValidatorDippingInAndOut) should be fixed in the PR directly.

@julienrbrt julienrbrt merged commit a6e5fe2 into marko/IS Oct 4, 2022
@julienrbrt julienrbrt deleted the julien/IS branch October 4, 2022 20:08
tac0turtle added a commit that referenced this pull request Oct 9, 2022
* feat: IS rebase (squash da53124..b45dd5f)

* clean up docs

* fix: fix IS tests (#13420)

* revert key update

* add hook error handling

* impl feedback

* add changelog

* implements style nits
Co-authored-by: Aleksandr Bezobchuk <[email protected]>

* more nits

* fix tests
Co-authored-by: Simon <[email protected]>

* add godoc

* add godoc

Co-authored-by: Julien Robert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants