Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add constitution to genesis state #14057

Closed
wants to merge 12 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Nov 29, 2022

Description

Closes: numerous existential debates

"but what is it for?!", asked the masses, of the highly repurposable state machine.

Well, till just now, there really wasn't any clear direction to blockchains built with the
cosmos-sdk.

The role of validator remained... difficult to define.

The purpose of chains remained... according to some -- intentionally unclear.

Never, fear, the constitution is here! For classic mode, just leave it "" in your genesis.json,
and float adrift without purpose. The constitution is intentionally immutable at this time, it
is another factor that the validators assent to when they begin to sign at genesis and bring the
chain to life:

Purpose, direction, a solid foundation. We need these things.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat requested a review from a team as a code owner November 29, 2022 07:13
@faddat faddat changed the title gov: Add constitution to genesis state feat: Add constitution to genesis state Nov 29, 2022
@julienrbrt
Copy link
Member

We cannot change all the field numbers because it is proto breaking.
We can simply add that field at the bottom of the proto message.

@faddat
Copy link
Contributor Author

faddat commented Nov 29, 2022

Thanks @julienrbrt -- I was wondering about the right way to do it <3

@tac0turtle
Copy link
Member

I think this needs a discussion there are some things that come to mind that this doesn't cover. Namely, how does a community member propose changes to the constitution? right now it looks to be a chain migration. Secondly how does this differ from a text proposal on chain that is named constitution, it holds the same value as this(?)

@tac0turtle tac0turtle marked this pull request as draft November 29, 2022 11:48
@tac0turtle
Copy link
Member

lets open an issue or discussion on this topic and close the PR till we have a clear understanding of how this feature should be added to the cosmos-sdk. @faddat could you open a discussion or issue on this?

@tac0turtle tac0turtle closed this Nov 29, 2022
@faddat
Copy link
Contributor Author

faddat commented Nov 29, 2022

Yeah, totally. I'm going to finish getting it squared away, but the idea is that just like genesis state generally, the people making the chain create the constitution, and it's immutable. Amendment=fork.

@faddat faddat mentioned this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants