feat: add config iavl-lazy-loading to enable lazy loading of iavl store
#14189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
commented
Dec 7, 2022
yihuang
force-pushed
the
iavl-lazy-loading
branch
2 times, most recently
from
d14d643 to
cdcfc1d
Compare
yihuang
changed the title
iavl-lazy-loading to enable lazy loading of iavl storeiavl-lazy-loading to enable lazy loading of iavl store
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
unstall |
improve start time of archive nodes. Update CHANGELOG.md fix test
yihuang
force-pushed
the
iavl-lazy-loading
branch
from
306a047 to
cc84e97
Compare
improve start time of archive nodes. Update CHANGELOG.md fix test
|
@yihuang want to update this to alpha.2? |
done, added a bunch of replacements to make it build though, not sure what's the best way to do it, do I need to make a separate PR for store package? |
github-prbot
requested review from
a team,
kocubinski and
amaury1093
and removed request for
a team
tac0turtle
added
the
A:automerge
|
can we backport to 0.47 and 0.46, it's important UX improvement for existing chains. @tac0turtle |
|
@Mergifyio backport release/v0.46.x |
|
@Mergifyio backport release/v0.47.x |
|
heads up these prs will need to be reduced to 0.19.5 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
…tore (#14189) Co-authored-by: Marko <[email protected]> (cherry picked from commit b266522) # Conflicts: # CHANGELOG.md # go.mod # go.sum # simapp/go.mod # simapp/go.sum # store/go.mod # store/go.sum # tests/go.mod # tests/go.sum # x/nft/go.mod # x/nft/go.sum # x/upgrade/go.mod # x/upgrade/go.sum
✅ Backports have been created
|
yihuang
added a commit
to yihuang/cosmos-sdk
that referenced
this pull request
Feb 1, 2023
…tore (cosmos#14189) Co-authored-by: Marko <[email protected]> (cherry picked from commit b266522) # Conflicts: # CHANGELOG.md # cosmovisor/go.sum # go.mod # go.sum # server/util.go # simapp/go.mod # simapp/go.sum # store/go.mod # store/go.sum # tests/go.mod # tests/go.sum # x/nft/go.mod # x/upgrade/go.mod # x/upgrade/go.sum
julienrbrt
pushed a commit
that referenced
this pull request
Feb 1, 2023
…tore (backport #14189) (#14863) Co-authored-by: yihuang <[email protected]> Co-authored-by: marbar3778 <[email protected]>
tac0turtle
added a commit
that referenced
this pull request
Feb 2, 2023
…tore (backport #14189) (#14862) Co-authored-by: yihuang <[email protected]> Co-authored-by: marbar3778 <[email protected]>
19 tasks
SpicyLemon
added a commit
to provenance-io/cosmos-sdk
that referenced
this pull request
Feb 16, 2023
…518) * fix: Fix Evidence CLI query flag parsing (backport cosmos#13458) (cosmos#14799) Co-authored-by: Likhita Polavarapu <[email protected]> Co-authored-by: HuangYi <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: nested iterator on cache store (cosmos#14798) * chore: update IAVL (backport cosmos#14830) (cosmos#14835) Co-authored-by: Marko <[email protected]> * Mark v0.46.8-pio-2 in the changelog and release notes. * feat: add config `iavl-lazy-loading` to enable lazy loading of iavl store (backport cosmos#14189) (cosmos#14862) Co-authored-by: yihuang <[email protected]> Co-authored-by: marbar3778 <[email protected]> * chore: bump IAVL to v0.19.5 (backport cosmos#14889) (cosmos#14892) Co-authored-by: Julien Robert <[email protected]> * build(deps): bump tendermint to v0.34.25 (cosmos#14903) * build(deps): bump tendermint to v0.34.26 (cosmos#14911) * fix: return named error for write validators (backport cosmos#14919) (cosmos#14921) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> * Bump Tendermint to v0.34.25 (from v0.34.24). (#498) * Fix a few listener proto comments. (#499) * build(deps): bump btcd in v0.46 (cosmos#14846) Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Elias Naur <[email protected]> Co-authored-by: Marko <[email protected]> * ci: update release slack channel and algolia api key (backport cosmos#14942) (cosmos#14945) Co-authored-by: Julien Robert <[email protected]> * feat: support profiling block replay during abci handshake (backport cosmos#14953) (cosmos#14964) Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]> * Revert "Revert cosmos#14349 - cache iterator optimizations (#444)" This reverts commit cd9d192. * Mark v0.46.8-pio-3 in the changelog and release notes. * fix: avoid broadcasting tx through query (backport cosmos#15044) (cosmos#15047) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Julien Robert <[email protected]> * Add CLI commands for sanction Tx gov props (#510) * Fix the changelog. --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Likhita Polavarapu <[email protected]> Co-authored-by: HuangYi <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: mmsqe <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Elias Naur <[email protected]> Co-authored-by: Facundo Medica <[email protected]>
ankurdotb
pushed a commit
to cheqd/cosmos-sdk
that referenced
this pull request
Feb 28, 2023
…tore (backport cosmos#14189) (cosmos#14862) Co-authored-by: yihuang <[email protected]> Co-authored-by: marbar3778 <[email protected]>
tsenart
pushed a commit
to meka-dev/cosmos-sdk
that referenced
this pull request
Apr 12, 2023
…tore (cosmos#14189) Co-authored-by: Marko <[email protected]>
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
…tore (cosmos#14189) Co-authored-by: Marko <[email protected]>
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
…tore (backport cosmos#14189) (cosmos#14862) Co-authored-by: yihuang <[email protected]> Co-authored-by: marbar3778 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It improve start time of archive nodes (from dozens of minutes to seconds).
It seems to be running alright on production node, but not sure of unknown side effects.
related: cosmos/iavl#638
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change