Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(context): Pass EventManager to the context as an interface. (backport #14384) #14386

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 22, 2022

This is an automatic backport of pull request #14384 done by Mergify.
Cherry-pick of ebf1e86 has failed:

On branch mergify/bp/release/v0.47.x/pr-14384
Your branch is up to date with 'origin/release/v0.47.x'.

You are currently cherry-picking commit ebf1e86bd.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   types/context.go
	modified:   types/events.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

#14384)

(cherry picked from commit ebf1e86)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot requested a review from a team as a code owner December 22, 2022 06:17
@mergify mergify bot added the conflicts label Dec 22, 2022
@tac0turtle
Copy link
Member

sorry we cant backport this for 0.47. We have a feature freeze, otherwise we will need to re audit

@tac0turtle tac0turtle closed this Dec 22, 2022
@mergify mergify bot deleted the mergify/bp/release/v0.47.x/pr-14384 branch December 22, 2022 11:35
@itsdevbear
Copy link

@tac0turtle all G, thought I'd try 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants