Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cosmos-sdk v0.42.x, modernized for easier migrations #14427

Closed

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Dec 27, 2022

Description

This is where I'm heading with solutions to this:

#14426


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@tac0turtle
Copy link
Member

why is this version being worked on, this version has reached EOL? Please don't do linting on older releases, it makes it harder to review.

@tac0turtle
Copy link
Member

closing this till we have consent in the issue

@tac0turtle tac0turtle closed this Dec 27, 2022
@faddat
Copy link
Contributor Author

faddat commented Dec 27, 2022

ok man no worries, I'll continue to grind on it and give some more reasoning behind it for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants