Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for []string and []int in draft-proposal prompt. #14483

Merged
merged 13 commits into from
Jan 5, 2023
Merged

feat: Add support for []string and []int in draft-proposal prompt. #14483

merged 13 commits into from
Jan 5, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jan 4, 2023 •
edited
Loading

Description

Follow-up of #14472 and #14465

  • add more docs
  • add draft-proposal support for []slice of []int
  • fix proposers that was not set in group draft-proposal

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-prbot github-prbot requested review from a team, amaury1093 and testinginprod and removed request for a team January 4, 2023 20:09
@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Jan 4, 2023
@julienrbrt julienrbrt marked this pull request as ready for review January 4, 2023 23:04
@julienrbrt julienrbrt requested a review from a team as a code owner January 4, 2023 23:04
@julienrbrt julienrbrt requested a review from tac0turtle January 4, 2023 23:18
julienrbrt
julienrbrt commented Jan 5, 2023
View reviewed changes
x/auth/module.go
@@ -31,7 +31,7 @@ import (
)

// ConsensusVersion defines the current x/auth module consensus version.
const ConsensusVersion = 5
const ConsensusVersion = 4
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment made me re-check everything: #14482 (comment) and this was bumped with the params changes already.

amaury1093
amaury1093 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

likhita-809
likhita-809 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julienrbrt julienrbrt enabled auto-merge (squash) January 5, 2023 11:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

facundomedica
facundomedica approved these changes Jan 5, 2023
View reviewed changes
x/group/README.md Show resolved Hide resolved
x/group/README.md Show resolved Hide resolved
x/gov/client/cli/prompt.go Outdated Show resolved Hide resolved
alexanderbez
alexanderbez approved these changes Jan 5, 2023
View reviewed changes
x/gov/client/cli/prompt.go
switch v.Field(i).Type().Elem().Kind() {
case reflect.String:
v.Field(i).Set(reflect.ValueOf([]string{result}))
case reflect.Int:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case reflect.Int:
case reflect.Int:

@julienrbrt julienrbrt merged commit 701aaa8 into main Jan 5, 2023
@julienrbrt julienrbrt deleted the julien/draft-proposal-metadata branch January 5, 2023 17:04
@mergify mergify bot mentioned this pull request Jan 5, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jan 5, 2023
@julienrbrt @mergify
feat: Add support for []string and []int in draft-proposal prom…
53dd164 
…pt. (#14483)

(cherry picked from commit 701aaa8)

# Conflicts:
#	CHANGELOG.md
#	x/gov/types/metadata.go
julienrbrt added a commit that referenced this pull request Jan 5, 2023
@mergify @julienrbrt
feat: Add support for []string and []int in draft-proposal prom…
b2612a9 
…pt. (backport #14483) (#14507)

Co-authored-by: Julien Robert <[email protected]>
This was referenced Apr 14, 2023
Merged
Merged
@0xstepit 0xstepit mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhita-809 likhita-809 likhita-809 approved these changes

@facundomedica facundomedica facundomedica approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@testinginprod testinginprod Awaiting requested review from testinginprod testinginprod is a code owner

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release C:CLI C:x/auth C:x/gov C:x/group
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@julienrbrt @amaury1093 @alexanderbez @facundomedica @likhita-809