chore: move precommit & preparecheckstate to core api

[tac0turtle]

Description

Closes: #15914

move precommit and preparecheck states to core api

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[julienrbrt]

lgtm! You'll need to add a replace in tests I think.
Could you as well rename the interface in https://github.com/cosmos/cosmos-sdk/blob/93d64cc/docs/docs/building-modules/01-module-manager.md ?

[alexanderbez]

What is "PrepareCheckState"? Where and when is it used by a module?

[julienrbrt]

https://github.com/cosmos/cosmos-sdk/blob/93d64cc/docs/docs/building-modules/01-module-manager.md#preparecheckstateappmodule

[alexanderbez]

I see. That doc/section is malformed making it very difficult to read.

[aaronc]

The PR type should be feat.

If we have these callbacks they should they include the request type? What would a module do in these callbacks?

[tac0turtle]

this is only a follow up to move the interfaces to core as they were added to module.go in #14860. There isnt a request type here to use, this is mainly to set some states before writing to disk and before executing that are outside of begin and endblock. Dydx and berachain are using these currently

[aaronc]

Okay makes sense. I'd like to better understand when and how these should be used. I see the module docs but it's not clear what I would actually do as a module developer or why.

[aaronc]

How would PrepareCheckState and Precommit be called in an app that is based on Rollkit or another consensus engine besides Comet? Are they still relevant there? If not, they shouldn't go in core/appmodule, but in core/comet probably

[tac0turtle]

How would PrepareCheckState and Precommit be called in an app that is based on Rollkit or another consensus engine besides Comet? Are they still relevant there? If not, they shouldn't go in core/appmodule, but in core/comet probably

these methods are agnostic to consensus engines. They only relate to application state. In the future if comet removes some of these calls in abci these calls would be moved elsewhere as they are still useful