Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(store/v2): Fix PebbleDB Iteration Edge Cases #18948
fix(store/v2): Fix PebbleDB Iteration Edge Cases #18948
Changes from 4 commits
c00509e
1603129
c1f8dfe
ffa58c6
252b87e
786827a
525382b
a2c09d9
c730f29
ced49f3
d7ac611
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of
panic
should be replaced with proper error handling to prevent application crashes due to malformed MVCC keys.Committable suggestion
The panic in the
Next
method when encountering a malformed MVCC key is a drastic measure that could cause the entire application to crash. Consider replacing this with proper error handling that allows the application to recover gracefully from such an error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for handling reverse iteration and seeking to the next prefix seems to be missing the actual implementation for reverse iteration, as the
SeekLT
method is called regardless of theitr.reverse
value. This could be an oversight or incomplete implementation. The code should either implement the reverse iteration logic or remove theitr.reverse
check if reverse iteration is not supported.