refactor: using slices.Contains to simplify the code

[luchenhan]

Description

using slices.Contains to simplify the code

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• Refactor
  • Simplified the logic for checking wildcard characters in the streaming functionality
  • Replaced manual loop with a more efficient slice containment check

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces a change in the baseapp/streaming.go file, specifically modifying the exposeAll function. The modification involves using the slices package to replace a manual loop-based check for the wildcard character "*" with the more concise slices.Contains method. This change simplifies the function's implementation while maintaining its original functionality of checking if a list contains a wildcard element.

Changes

File	Change Summary
baseapp/streaming.go	Replaced manual loop with slices.Contains to check for wildcard "*" in the exposeAll function

Possibly related PRs

• refactor(x/slashing): remove extra get #22376: The changes in this PR involve modifying the logic in the HandleValidatorSignatureWithParams method, which may relate to the overall code structure and logic handling in the baseapp/streaming.go file, although they do not directly affect the same functions or variables.

Suggested reviewers

• tac0turtle
• auricom
• julienrbrt
• testinginprod
• sontrinh16

---

📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0655a29 and e242404.

📒 Files selected for processing (1)

• baseapp/streaming.go (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• baseapp/streaming.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 07d5168 and 0655a29.

📒 Files selected for processing (1)

• baseapp/streaming.go (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

baseapp/streaming.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

🪛 golangci-lint (1.62.2)

baseapp/streaming.go

8-8: File is not gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order

(gci)

🪛 GitHub Actions: Lint

baseapp/streaming.go

[error] 7-8: File is not properly formatted with 'gci'. Imports need to be ordered according to --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order

---

[error] 6-6: File is not properly formatted with 'gofumpt -extra'

🔇 Additional comments (1)

baseapp/streaming.go (1)

119-119: Confirm minimum Go version for slices usage
Using slices.Contains is a great refactor. However, it requires Go 1.21 or later. Ensure your module’s go.mod specifies an adequate Go version and that your build environment supports it.

You can run the following script to check the declared Go version in go.mod:

✅ Verification successful

Go version requirement is satisfied
The codebase uses Go 1.23.2 as specified in go.mod, which is well above the minimum requirement of Go 1.21 needed for slices.Contains. The usage of this package is safe in this context.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Confirm that go.mod declares Go 1.21 or later

rg -A 2 'go ' go.mod

Length of output: 1518

[julienrbrt]

ACK, thanks