chore(x/slashing,x/protocolpool): use cosmossdk.io/core/codec instead of github.com/cosmos/cosmos-sdk/codec
#23291
Conversation
… of github.com/cosmos/cosmos-sdk/codec
caseylove
requested review from
raynaudoe,
lucaslopezf,
a team and
alpe
as code owners
|
Warning Rate limit exceeded@julienrbrt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 20 minutes and 23 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request introduces modifications to two files in the Cosmos SDK, focusing on codec import updates and error handling improvements. The changes primarily involve replacing the codec import from Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
caseylove
changed the title
cosmossdk.io/core/codec instead of github.com/cosmos/cosmos-sdk/codec
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
x/protocolpool/module.go(2 hunks)x/slashing/migrations/v4/migrate.go(3 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
x/protocolpool/module.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
x/slashing/migrations/v4/migrate.go (1)
Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
🪛 golangci-lint (1.62.2)
x/protocolpool/module.go
16-16: File is not gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order
(gci)
x/slashing/migrations/v4/migrate.go
14-14: File is not gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order
(gci)
🪛 GitHub Actions: Lint
x/protocolpool/module.go
[error] 11-11: File is not gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order
[error] 16-16: File is not gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: tests (03)
- GitHub Check: tests (02)
- GitHub Check: tests (01)
- GitHub Check: tests (00)
- GitHub Check: test-simapp-v2
- GitHub Check: test-system-v2
- GitHub Check: test-integration
- GitHub Check: Analyze
- GitHub Check: build (amd64)
- GitHub Check: Summary
🔇 Additional comments (2)
x/protocolpool/module.go (1)
83-87: LGTM! Improved error handling in DefaultGenesis.The change from
MustMarshalJSONto explicit error handling withMarshalJSONprovides better error context when marshaling fails.x/slashing/migrations/v4/migrate.go (1)
77-79: LGTM! Improved error handling in unmarshal operations.The change from
MustUnmarshalto explicit error handling withUnmarshalprovides better error context when unmarshaling fails.Also applies to: 102-104
x/protocolpool/module.go
Outdated
| @@ -13,8 +13,8 @@ import ( | |||
| "cosmossdk.io/x/protocolpool/keeper" | |||
| "cosmossdk.io/x/protocolpool/types" | |||
|
|
|||
| "cosmossdk.io/core/codec" | |||
There was a problem hiding this comment.
💡 Codebase verification
Reorder imports in the cosmossdk.io group
The import cosmossdk.io/core/codec should be grouped with other cosmossdk.io/core imports. Move it before the cosmossdk.io/x imports to maintain alphabetical ordering within its group:
import (
"context"
"encoding/json"
"fmt"
gwruntime "github.com/grpc-ecosystem/grpc-gateway/runtime"
"google.golang.org/grpc"
"cosmossdk.io/core/appmodule"
"cosmossdk.io/core/codec"
"cosmossdk.io/core/registry"
"cosmossdk.io/x/protocolpool/keeper"
"cosmossdk.io/x/protocolpool/types"
"github.com/cosmos/cosmos-sdk/client"
"github.com/cosmos/cosmos-sdk/types/module"
)🔗 Analysis chain
Fix import ordering according to project guidelines.
The import statement needs to be reordered according to the project's import grouping rules:
- Standard library
- Third-party
- First-party (cosmossdk.io)
- Local packages
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify import ordering rules across the codebase
gci diff --skip-generated -s standard -s default -s "prefix(cosmossdk.io)" -s "prefix(github.com/cosmos/cosmos-sdk)" x/protocolpool/module.go
Length of output: 237
Script:
#!/bin/bash
# Get the import block to analyze ordering
rg -U "import \($" -A 20 x/protocolpool/module.go
Length of output: 543
🧰 Tools
🪛 golangci-lint (1.62.2)
16-16: File is not gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order
(gci)
🪛 GitHub Actions: Lint
[error] 16-16: File is not gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order
x/slashing/migrations/v4/migrate.go
Outdated
| @@ -11,7 +11,7 @@ import ( | |||
| storetypes "cosmossdk.io/store/types" | |||
| "cosmossdk.io/x/slashing/types" | |||
|
|
|||
| "github.com/cosmos/cosmos-sdk/codec" | |||
| "cosmossdk.io/core/codec" | |||
There was a problem hiding this comment.
💡 Codebase verification
Imports need to be reorganized for consistency
The imports should be grouped in the following order:
- Standard library imports ("context")
- Third-party imports (bitset, gogoproto)
- cosmossdk.io imports (core, errors, store, slashing)
- cosmos-sdk imports
🔗 Analysis chain
Fix import ordering according to project guidelines.
The import statement needs to be reordered according to the project's import grouping rules:
- Standard library
- Third-party
- First-party (cosmossdk.io)
- Local packages
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify import ordering rules across the codebase
gci diff --skip-generated -s standard -s default -s "prefix(cosmossdk.io)" -s "prefix(github.com/cosmos/cosmos-sdk)" x/slashing/migrations/v4/migrate.go
Length of output: 248
Script:
#!/bin/bash
# Get imports section from the file and similar migration files
echo "=== Current file imports ==="
rg -U "^import \($" -A 20 "x/slashing/migrations/v4/migrate.go"
echo -e "\n=== Other migration files imports for comparison ==="
fd "migrate.go" --exec rg -U "^import \($" -A 20 {} \;
Length of output: 5483
🧰 Tools
🪛 golangci-lint (1.62.2)
14-14: File is not gci-ed with --skip-generated -s standard -s default -s prefix(cosmossdk.io) -s prefix(github.com/cosmos/cosmos-sdk) --custom-order
(gci)
julienrbrt
added
the
backport/v0.52.x
|
To merge into #23313 |
Description
Partially addresses #23253
Summary by CodeRabbit
Refactor
github.com/cosmos/cosmos-sdk/codectocosmossdk.io/core/codecChores
MustMarshalJSONandMustUnmarshalwith explicit error handling approaches