R4R: Account numbers and sequences to uint64 #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnya97
requested review from
cwgoes,
ebuchman,
rigelrozanski and
zramsay
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2799 +/- ##
========================================
Coverage 56.84% 56.84%
========================================
Files 120 120
Lines 8298 8298
========================================
Hits 4717 4717
Misses 3263 3263
Partials 318 318 |
sunnya97
force-pushed
the
sunny/unsigned-accnum-sequence
branch
from
5914a77 to
76c5458
Compare
sunnya97
changed the title
sunnya97
added
ready-for-review
T: API Breaking
cwgoes
reviewed
Nov 15, 2018
|
It should only ever be monotonically increasing. Technically, even if we implement this: #1217 |
cwgoes
approved these changes
Nov 16, 2018
| @@ -38,10 +38,10 @@ func NewTxBuilderFromCLI() TxBuilder { | |||
|
|
|||
| return TxBuilder{ | |||
| ChainID: chainID, | |||
| AccountNumber: viper.GetInt64(client.FlagAccountNumber), | |||
| AccountNumber: uint64(viper.GetInt64(client.FlagAccountNumber)), | |||
There was a problem hiding this comment.
This could be confusing if the user enters a negative number, maybe we should sanity check the input
| Gas: client.GasFlagVar.Gas, | ||
| GasAdjustment: viper.GetFloat64(client.FlagGasAdjustment), | ||
| Sequence: viper.GetInt64(client.FlagSequence), | ||
| Sequence: uint64(viper.GetInt64(client.FlagSequence)), |
alexanderbez
previously requested changes
Nov 16, 2018
There was a problem hiding this comment.
Changes LGTM -- I would just suggest updating PostCommands to add these two flags as uints:
c.Flags().Uint64(FlagAccountNumber, 0, "AccountNumber number to sign the tx")
c.Flags().Uint64(FlagSequence, 0, "Sequence number to sign the tx")This way, I don't think we need to sanity check as @cwgoes suggested.
|
many merge conflicts here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2701
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added entries in
PENDING.mdwith issue #rereviewed
Files changedin the github PR explorerFor Admin Use: