Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Move generate_only and simulate to POST body in REST txs #3060

Merged
merged 5 commits into from
Dec 10, 2018
Merged

R4R: Move generate_only and simulate to POST body in REST txs #3060

merged 5 commits into from
Dec 10, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Dec 10, 2018 •
edited by fedekunze
Loading

Closes: #3056

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio alessio added the wip label Dec 10, 2018
@alessio alessio changed the title WIP: Alessio/3056 args to post body WIP: Move generate_only and simulate to POST body in REST txs Dec 10, 2018
@codecov
Copy link

codecov bot commented Dec 10, 2018 •
edited
Loading

Codecov Report

Merging #3060 into develop will decrease coverage by <.01%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop    #3060      +/-   ##
===========================================
- Coverage    52.14%   52.14%   -0.01%     
===========================================
  Files          136      136              
  Lines         9613     9612       -1     
===========================================
- Hits          5013     5012       -1     
  Misses        4264     4264              
  Partials       336      336

@alessio alessio changed the title WIP: Move generate_only and simulate to POST body in REST txs R4R: Move generate_only and simulate to POST body in REST txs Dec 10, 2018
fedekunze
fedekunze reviewed Dec 10, 2018
View reviewed changes
x/stake/keeper/test_common.go
@@ -227,15 +227,14 @@ func TestingUpdateValidator(keeper Keeper, ctx sdk.Context, validator types.Vali
panic("validator expected but not found")
}
return validator
} else {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol everyone's fixing this on their PRs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, that makes linter fail

fedekunze
fedekunze reviewed Dec 10, 2018
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Can you update the docs on swagger.yaml as well ?

alexanderbez
alexanderbez approved these changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be a lot of superfluous imports changes, how come? In any case, changes LGTM. I have a feeling though some documentation (Swagger?) needs to be updated.

@alessio
Copy link
Contributor Author

alessio commented Dec 10, 2018

@alexanderbez I ran make format

@alessio
Copy link
Contributor Author

alessio commented Dec 10, 2018

@fedekunze swagger.yaml is now up to date

fedekunze
fedekunze approved these changes Dec 10, 2018
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM. thanks !

@fedekunze fedekunze mentioned this pull request Dec 10, 2018
Merged
6 tasks
@jackzampolin jackzampolin merged commit e1f0767 into develop Dec 10, 2018
@jackzampolin jackzampolin deleted the alessio/3056-args-to-post-body branch December 10, 2018 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@zramsay zramsay Awaiting requested review from zramsay

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio @alexanderbez @fedekunze @jackzampolin