Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: tx generate only #3287

Closed
wants to merge 14 commits into from
Closed

WIP: tx generate only #3287

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8d2e497
only validate for name if not generate only
faboweb Jan 12, 2019
ad720e2
added from to base_req
faboweb Jan 12, 2019
77122e2
added from
faboweb Jan 12, 2019
e0e5252
Merge branch 'fabo/generate_only' of https://github.com/cosmos/cosmos…
faboweb Jan 12, 2019
dea8011
added generate only handler to more endpoints
faboweb Jan 12, 2019
e2a429b
added error checking for from
faboweb Jan 12, 2019
5311266
added ability to generate only
faboweb Jan 14, 2019
0ee55aa
added tests
faboweb Jan 14, 2019
8e3f099
added pending
faboweb Jan 14, 2019
bdf633e
updated swagger
faboweb Jan 14, 2019
025606d
updated swagger
faboweb Jan 14, 2019
5202cf1
Merge branch 'fabo/generate_only' of https://github.com/cosmos/cosmos…
faboweb Jan 14, 2019
1b897fd
fixed tests and switched to using sdk.AccAddress for from
faboweb Jan 14, 2019
ba36ca4
Update client/lcd/swagger-ui/swagger.yaml
fedekunze Jan 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions PENDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ FEATURES
* [\#3069](https://github.com/cosmos/cosmos-sdk/pull/3069) Add a custom memo on transactions
* [\#3027](https://github.com/cosmos/cosmos-sdk/issues/3027) Implement
`/gov/proposals/{proposalID}/proposer` to query for a proposal's proposer.
* [\#3284](https://github.com/cosmos/cosmos-sdk/issues/3284) Implement generation of txs without account.

* Gaia CLI (`gaiacli`)
* \#2399 Implement `params` command to query slashing parameters.
Expand Down
35 changes: 30 additions & 5 deletions client/lcd/lcd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ func TestCoinSendGenerateSignAndBroadcast(t *testing.T) {
payload := authrest.SignBody{
Tx: msg,
BaseReq: utils.NewBaseReq(
name1, pw, "", viper.GetString(client.FlagChainID), "", "", accnum, sequence, nil, false, false,
name1, pw, "", "", viper.GetString(client.FlagChainID), "", "", accnum, sequence, nil, false, false,
),
}
json, err := cdc.MarshalJSON(payload)
Expand Down Expand Up @@ -399,8 +399,17 @@ func TestBonding(t *testing.T) {
acc := getAccount(t, port, addr)
initialBalance := acc.GetCoins()

var resultTx ctypes.ResultBroadcastTxCommit
var tx auth.StdTx
// generate bond TX
body := doDelegate(t, port, name1, pw, addr, operAddrs[0], 60, fees, true)
err := cdc.UnmarshalJSON([]byte(body), &tx)
require.Nil(t, err)

// create bond TX
resultTx := doDelegate(t, port, name1, pw, addr, operAddrs[0], 60, fees)
body = doDelegate(t, port, name1, pw, addr, operAddrs[0], 60, fees, false)
err = cdc.UnmarshalJSON([]byte(body), &resultTx)
require.Nil(t, err)
tests.WaitForHeight(resultTx.Height+1, port)

require.Equal(t, uint32(0), resultTx.CheckTx.Code)
Expand Down Expand Up @@ -441,8 +450,15 @@ func TestBonding(t *testing.T) {
bondedValidator := getDelegatorValidator(t, port, addr, operAddrs[0])
require.Equal(t, operAddrs[0], bondedValidator.OperatorAddr)

// generate unbond TX
body = doBeginUnbonding(t, port, name1, pw, addr, operAddrs[0], 60, fees, true)
err = cdc.UnmarshalJSON([]byte(body), &tx)
require.Nil(t, err)

// testing unbonding
resultTx = doBeginUnbonding(t, port, name1, pw, addr, operAddrs[0], 30, fees)
body = doBeginUnbonding(t, port, name1, pw, addr, operAddrs[0], 30, fees, false)
err = cdc.UnmarshalJSON([]byte(body), &resultTx)
require.Nil(t, err)
tests.WaitForHeight(resultTx.Height+1, port)

require.Equal(t, uint32(0), resultTx.CheckTx.Code)
Expand Down Expand Up @@ -470,8 +486,15 @@ func TestBonding(t *testing.T) {
unbonding := getUndelegation(t, port, addr, operAddrs[0])
require.Equal(t, int64(30), unbonding.Balance.Amount.Int64())

// generate redelegation TX
body = doBeginRedelegation(t, port, name1, pw, addr, operAddrs[0], operAddrs[1], 30, fees, true)
err = cdc.UnmarshalJSON([]byte(body), &tx)
require.Nil(t, err)

// test redelegation
resultTx = doBeginRedelegation(t, port, name1, pw, addr, operAddrs[0], operAddrs[1], 30, fees)
body = doBeginRedelegation(t, port, name1, pw, addr, operAddrs[0], operAddrs[1], 30, fees, false)
err = cdc.UnmarshalJSON([]byte(body), &resultTx)
require.Nil(t, err)
tests.WaitForHeight(resultTx.Height+1, port)

require.Equal(t, uint32(0), resultTx.CheckTx.Code)
Expand Down Expand Up @@ -678,7 +701,9 @@ func TestVote(t *testing.T) {
require.Equal(t, sdk.ZeroDec(), tally.Yes, "tally should be 0 as the address is not bonded")

// create bond TX
resultTx = doDelegate(t, port, name1, pw, addr, operAddrs[0], 60, fees)
body := doDelegate(t, port, name1, pw, addr, operAddrs[0], 60, fees, false)
err := cdc.UnmarshalJSON([]byte(body), &resultTx)
require.Nil(t, err)
tests.WaitForHeight(resultTx.Height+1, port)

// verify balance
Expand Down
Loading