Allow custom key types and address formats #4232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er parameter to NewAnteHandler to allow for custom key types and address formats
Codecov Report
@@ Coverage Diff @@
## master #4232 +/- ##
==========================================
+ Coverage 60.18% 60.19% +<.01%
==========================================
Files 212 212
Lines 15187 15168 -19
==========================================
- Hits 9140 9130 -10
+ Misses 5418 5413 -5
+ Partials 629 625 -4 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4232 +/- ##
==========================================
+ Coverage 60.18% 60.19% +<.01%
==========================================
Files 212 212
Lines 15187 15168 -19
==========================================
- Hits 9140 9130 -10
+ Misses 5418 5413 -5
+ Partials 629 625 -4 |
Codecov Report
@@ Coverage Diff @@
## master #4232 +/- ##
==========================================
+ Coverage 60.18% 60.29% +0.11%
==========================================
Files 212 212
Lines 15187 15171 -16
==========================================
+ Hits 9140 9148 +8
+ Misses 5418 5403 -15
+ Partials 629 620 -9 |
aaronc
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
|
@alexanderbez I reopened #4166 over here and made the changes you requested. |
fedekunze
reviewed
Apr 29, 2019
alexanderbez
approved these changes
May 1, 2019
| @@ -86,6 +86,18 @@ func AccAddressFromHex(address string) (addr AccAddress, err error) { | |||
| return AccAddress(bz), nil | |||
| } | |||
|
|
|||
| func VerifyAddressFormat(bz []byte) error { | |||
There was a problem hiding this comment.
Can we add a quick godoc for this?
alexanderbez
added
ready-for-review
T: API Breaking
alessio
reviewed
May 1, 2019
alessio
reviewed
May 1, 2019
alessio
reviewed
May 1, 2019
alessio
reviewed
May 1, 2019
alessio
reviewed
May 1, 2019
| @@ -86,6 +86,18 @@ func AccAddressFromHex(address string) (addr AccAddress, err error) { | |||
| return AccAddress(bz), nil | |||
| } | |||
|
|
|||
| func VerifyAddressFormat(bz []byte) error { | |||
There was a problem hiding this comment.
It'd be nice to have a test case as well
alessio
suggested changes
May 1, 2019
|
oh lol, I've left essentially the same feedback as @alexanderbez, I didn't see it coming through. Please address the comments and feel free to dismiss my review 👍 EDIT: removed dup comments/suggestions |
Co-Authored-By: aaronc <[email protected]>
Co-Authored-By: aaronc <[email protected]>
…address formatting
alessio
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3685. (Was PR #4166 before the develop branch was removed.)
Adds:
NewAnteHandlerfor a customSignatureVerificationGasConsumer(the existing one is now called `DefaultSigVerificationGasConsumer)addressVerifierfield tosdk.Configwhich allows for custom address verification (to override the current fixed 20 byte address format)Changes:
DefaultSigVerificationGasConsumernow uses type switching as opposed to string comparison. Other zones like Ethermint can now concretely specify which key types they accept.Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: