More linters - Gosec, staticcheck

[tac0turtle]

ref #4589

• Added gosec, staticcheck

Signed-off-by: Marko Baricevic [email protected]

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added a relevant changelog entry: clog add [section] [stanza] [message]

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #4608 into master will decrease coverage by 0.83%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4608      +/-   ##
==========================================
- Coverage   53.63%   52.79%   -0.84%     
==========================================
  Files         260      264       +4     
  Lines       16178    16468     +290     
==========================================
+ Hits         8677     8695      +18     
- Misses       6855     7126     +271     
- Partials      646      647       +1

[alexanderbez]

ACK

[alessio]

We can't merge this in due to the removal of the lint build step from the CI config - @mircea-c can you help us please?

[mircea-c]

I'll see if I can fix this a little later tonight. Will probably have to manually update the check through the gihub api.

[mircea-c]

Guys, I tried to update this check manually, but it doesn't look like CircleCI is using the github checks api (possibly because it's still under active development)

To merge this you'll need a repo admin to disable the check from the branch protection rules:

https://circleci.com/docs/2.0/enable-checks/#github-checks-waiting-for-status-in-github

[alessio]

cc'ing @ebuchman @jaekwon then

[tac0turtle]

@jackzampolin do you have permissions?