keys: define proto type

[tac0turtle]

Description

This is a simpler approach to defining keys then redefining all the types.

cc @alexanderbez, @fedekunze let me know if your are fine with this approach

note: if a release of tendermint is used we will manually have to switch over the keys as [size]byte is used. this will be removed in the next release

Closes: #5819

Replaces #5868

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

---

For admin use:

• Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• Reviewers assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[tac0turtle]

@alexanderbez make proto-gen doesnt work when the folder structure is like so:

 multisig
    ├── bitarray
    │   ├── compact_bit_array.go
    │   ├── compact_bit_array_test.go
    │   └── types.proto
    ├── codec.go
    ├── multisignature.go
    ├── threshold_pubkey.go
    ├── threshold_pubkey_test.go
    └── types.proto

any suggestions on how to overcome this?

[alexanderbez]

@marbar3778 wdym it doesn't work? Do you have output or logs you can provide? AFAIK, codgen doesn't care where the *.proto files reside.

[tac0turtle]

logs:

20/04/21 00:02:48 protoc-gen-gogo: error:inconsistent package import paths: "github.com/cosmos/cosmos-sdk/crypto/keys/multisig", "github.com/cosmos/cosmos-sdk/crypto/keys/multisig/bitarry"
--gocosmos_out: protoc-gen-gocosmos: Plugin failed with status code 1.

i had the same issue in tendermint but had to separate things into different pkgs so didn't solve the issue.

[alexanderbez]

Mhh I'm not familiar with that error. However, bitarry has nothing to do with multisigs, right? Ideally, it should reside under types/.

[alessio]

Mhh I'm not familiar with that error. However, bitarry has nothing to do with multisigs, right? Ideally, it should reside under types/

Do we need to create a sub directory for it? Can we just merge it into the root types directory please?

[tac0turtle]

Do we need to create a sub directory for it? Can we just merge it into the root types directory please?

did that in my latest push

[alessio]

And how about placing multisig directory just under crypto instead of crypto/keys?

[alessio]

@marbar3778 tests are failing:

--- FAIL: TestThresholdMultisigValidCases (0.02s)
    threshold_pubkey_test.go:78: 
        	Error Trace:	threshold_pubkey_test.go:78
        	Error:      	Should be true
        	Test:       	TestThresholdMultisigValidCases
        	Messages:   	multisig failed after k good signatures, tc 0
FAIL
coverage: 28.1% of statements
FAIL	github.com/cosmos/cosmos-sdk/crypto/multisig	0.800s

(otherwise this looks good to me)

[aaronc]

LGTM. Just asked for the future deprecation notice to be clarified.

[aaronc]

Can you say a little bit more about why and what the condition is? Basically if interfacetype can be used right?

[aaronc]

Note that this might change based on our transition to Any (#6030, #6081).

Using a string for PubKey type would be most consistent with usage of Any. However, maybe it makes more sense to make it an enum or stick to a oneof.

Not sure where the best place is to discuss this is, maybe this PR? Or maybe we merge this and refactor later?

[tac0turtle]

havent been keeping up with the proto work. Will close this pr and possibly open once I understand what is the new path for proto