-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove totmPubkey #7652
remove totmPubkey #7652
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7652 +/- ##
==========================================
+ Coverage 54.14% 59.82% +5.68%
==========================================
Files 611 317 -294
Lines 38558 17988 -20570
==========================================
- Hits 20876 10761 -10115
+ Misses 15550 6079 -9471
+ Partials 2132 1148 -984 |
I'm going to revert the removal of totmpubkey, how tendermint keys are now used in the sdk complicates quite a lot and I don't want to spend time untangling something that seems to be done on purpose |
This sounds like a good move, I think |
@marbar3778 After our offline conversation, one of @blushi @robert-zaremba or me can take ownership of this PR to bring it over the finish line, does that sound good to you? |
I had a quick check with @marbar3778 about the status / support. Implementation is done, but we still need to update the tests. If I will have time later today, I will have a look at the tests. |
Description
remove to tmpubkeys
disentangle tendermint keys from the sdk
closes: #7529
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes