Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove totmPubkey #7652

Closed
wants to merge 5 commits into from
Closed

remove totmPubkey #7652

wants to merge 5 commits into from

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Oct 23, 2020

Description

remove to tmpubkeys
disentangle tendermint keys from the sdk

closes: #7529


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #7652 into master will increase coverage by 5.68%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7652      +/-   ##
==========================================
+ Coverage   54.14%   59.82%   +5.68%     
==========================================
  Files         611      317     -294     
  Lines       38558    17988   -20570     
==========================================
- Hits        20876    10761   -10115     
+ Misses      15550     6079    -9471     
+ Partials     2132     1148     -984     

@tac0turtle
Copy link
Member Author

I'm going to revert the removal of totmpubkey, how tendermint keys are now used in the sdk complicates quite a lot and I don't want to spend time untangling something that seems to be done on purpose

@colin-axner
Copy link
Contributor

I'm going to revert the removal of totmpubkey, how tendermint keys are now used in the sdk complicates quite a lot and I don't want to spend time untangling something that seems to be done on purpose

This sounds like a good move, I think staking needs to be refactored a bit before this move can be made. One too many assumptions that tendermint is the consensus algo being used

@amaury1093 amaury1093 self-assigned this Oct 28, 2020
@amaury1093
Copy link
Contributor

@marbar3778 After our offline conversation, one of @blushi @robert-zaremba or me can take ownership of this PR to bring it over the finish line, does that sound good to you?

@robert-zaremba
Copy link
Collaborator

I had a quick check with @marbar3778 about the status / support. Implementation is done, but we still need to update the tests. If I will have time later today, I will have a look at the tests.

@amaury1093
Copy link
Contributor

superseded by #7419 and #7838

@amaury1093 amaury1093 closed this Nov 6, 2020
@amaury1093 amaury1093 deleted the marko/remove_toTM2 branch November 6, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: secp256k1 consensus support
4 participants