Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename RegisterGRPCRoutes #7696

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Rename RegisterGRPCRoutes #7696

merged 3 commits into from
Oct 28, 2020

Conversation

anilcse
Copy link
Collaborator

@anilcse anilcse commented Oct 27, 2020

Description

closes: #7694


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@anilcse anilcse marked this pull request as ready for review October 27, 2020 21:24
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #7696 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #7696   +/-   ##
=======================================
  Coverage   54.12%   54.12%           
=======================================
  Files         611      611           
  Lines       38620    38620           
=======================================
  Hits        20902    20902           
  Misses      15582    15582           
  Partials     2136     2136           

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Oct 28, 2020
@mergify mergify bot merged commit 51ac6f8 into master Oct 28, 2020
@mergify mergify bot deleted the anil/rename_grpc_api branch October 28, 2020 11:39
clevinson pushed a commit that referenced this pull request Oct 29, 2020
* Rename

* Fix missing

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* Rename

* Fix missing

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename RegisterGRPCRoutes
3 participants