fix: add missing nil check in store.GetStore #9354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
requested review from
anilcse,
ryanchristo,
technicallyty and
aleem1314
Codecov Report
@@ Coverage Diff @@
## master #9354 +/- ##
==========================================
- Coverage 60.38% 60.31% -0.08%
==========================================
Files 587 588 +1
Lines 36920 36976 +56
==========================================
+ Hits 22294 22301 +7
- Misses 12651 12699 +48
- Partials 1975 1976 +1
|
amaury1093
approved these changes
May 19, 2021
amaury1093
added
the
A:automerge
aleem1314
approved these changes
May 19, 2021
mergify bot
pushed a commit
that referenced
this pull request
May 19, 2021
* fix: add missing nil check in store.GetStore * check nil in rootmulti as well (cherry picked from commit b065e20)
aaronc
pushed a commit
that referenced
this pull request
May 19, 2021
* fix: add missing nil check in store.GetStore * check nil in rootmulti as well (cherry picked from commit b065e20) Co-authored-by: Robert Zaremba <[email protected]>
roysc
pushed a commit
to vulcanize/cosmos-sdk
that referenced
this pull request
Jun 23, 2021
* fix: add missing nil check in store.GetStore * check nil in rootmulti as well
BananaLF
added a commit
to okx/exchain
that referenced
this pull request
Jun 27, 2022
Merged
5 tasks
xiangjianmeng
added a commit
to okx/exchain
that referenced
this pull request
Jun 28, 2022
…osmos-sdk#9354 ) (#2246) Co-authored-by: xiangjianmeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both
store.GetStoreandstore.GetKVStoreare missingnilchecks which yield to more ugly panics.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes