feat: update x/bank blocked addresses #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
requested review from
okwme,
zmanian,
yaruwangway,
jgimeno,
crodriguezvega,
cmwaters,
mmulji-ic,
glnro and
tokamak-git
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1493 +/- ##
==========================================
- Coverage 12.05% 11.97% -0.09%
==========================================
Files 9 9
Lines 1418 1428 +10
==========================================
Hits 171 171
- Misses 1241 1251 +10
Partials 6 6 |
glnro
reviewed
May 19, 2022
yaruwangway
reviewed
Jun 15, 2022
| // remove module accounts that are ALLOWED to received funds | ||
| // | ||
| // TODO: Blocked on updating to v0.46.x | ||
| // delete(modAccAddrs, authtypes.NewModuleAddress(grouptypes.ModuleName).String()) |
There was a problem hiding this comment.
we can uncomment this and merge ? main branch is already in sdk 0.46.
There was a problem hiding this comment.
Yes but I don't think the changes @alexanderbez made are in the release we're using, it's in 0.46.x not rc1
glnro
approved these changes
Jun 15, 2022
Merged
tokamak-git
pushed a commit
that referenced
this pull request
Jun 21, 2022
* updates * updates * updates * updates Co-authored-by: lg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the deny-list provided to
x/bankto allowx/govandx/groupss.t. that they can RECEIVE funds :)Blocked on: