-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat! [WIP] Break out LSM module from SDK #3455
base: main
Are you sure you want to change the base?
Conversation
Progress is a beautiful thing |
runtime.NewKVStoreService(keys[authtypes.StoreKey]), | ||
authtypes.ProtoBaseAccount, | ||
maccPerms, | ||
addresscodec.NewBech32Codec(sdk.Bech32MainPrefix), |
Check warning
Code scanning / CodeQL
Directly using the bech32 constants Warning test
authtypes.ProtoBaseAccount, | ||
maccPerms, | ||
addresscodec.NewBech32Codec(sdk.Bech32MainPrefix), | ||
sdk.Bech32MainPrefix, |
Check warning
Code scanning / CodeQL
Directly using the bech32 constants Warning test
) | ||
|
||
stakingKeeper := stakingkeeper.NewKeeper(cdc, runtime.NewKVStoreService(keys[stakingtypes.StoreKey]), | ||
accountKeeper, bankKeeper, authority.String(), addresscodec.NewBech32Codec(sdk.Bech32PrefixValAddr), addresscodec.NewBech32Codec(sdk.Bech32PrefixConsAddr)) |
Check warning
Code scanning / CodeQL
Directly using the bech32 constants Warning test
) | ||
|
||
stakingKeeper := stakingkeeper.NewKeeper(cdc, runtime.NewKVStoreService(keys[stakingtypes.StoreKey]), | ||
accountKeeper, bankKeeper, authority.String(), addresscodec.NewBech32Codec(sdk.Bech32PrefixValAddr), addresscodec.NewBech32Codec(sdk.Bech32PrefixConsAddr)) |
Check warning
Code scanning / CodeQL
Directly using the bech32 constants Warning test
Description
Closes: #XXXX
Splits out all of the lsm code from the SDK fork into its own module.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump).changelog
(for details, see contributing guidelines)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change