Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove double registration warning #67

Merged
merged 2 commits into from
May 11, 2023
Merged

chore: remove double registration warning #67

merged 2 commits into from
May 11, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt requested a review from a team as a code owner May 11, 2023 10:01
@julienrbrt julienrbrt marked this pull request as draft May 11, 2023 10:09
@julienrbrt julienrbrt marked this pull request as ready for review May 11, 2023 10:37
@julienrbrt julienrbrt requested a review from tac0turtle May 11, 2023 11:57
@julienrbrt julienrbrt linked an issue May 11, 2023 that may be closed by this pull request
New warnings with v1.4.9 #66
Closed
aaronc
aaronc approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay approving this, but I'm not sure it's not useful for other cases. But probably fine unless we hit an issue

@julienrbrt
Copy link
Member Author

I'm okay approving this, but I'm not sure it's not useful for other cases. But probably fine unless we hit an issue

I was thinking of passing a logger but that was more breaking.
Do you think it is worth it?

@julienrbrt julienrbrt merged commit 28c37ed into main May 11, 2023
@julienrbrt julienrbrt deleted the julien/remove-warning branch May 11, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronc aaronc aaronc approved these changes

@tac0turtle tac0turtle Awaiting requested review from tac0turtle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New warnings with v1.4.9 proto: file "google/protobuf/any.proto" already registered
2 participants
@julienrbrt @aaronc