Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analyzer.go: add support for nested go modules #23

Merged
merged 3 commits into from
Jun 9, 2022
Merged

analyzer.go: add support for nested go modules #23

merged 3 commits into from
Jun 9, 2022

Conversation

kirbyquerby
Copy link
Collaborator

This change adds support for analyzing projects with more than one go.mod. This will let us run this tool on https://github.com/cosmos/cosmos-sdk

Updates cosmos/cosmos-sdk#10572
Related: securego/gosec#501

This change adds support for analyzing projects with more than one go.mod. This will let us run this tool on https://github.com/cosmos/cosmos-sdk

Updates cosmos/cosmos-sdk#10572
Related: securego/gosec#501
@kirbyquerby kirbyquerby marked this pull request as draft June 8, 2022 23:09
@kirbyquerby kirbyquerby marked this pull request as ready for review June 8, 2022 23:26
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2022

Codecov Report

Merging #23 (161133d) into master (d50c2b8) will decrease coverage by 0.31%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   71.05%   70.74%   -0.32%     
==========================================
  Files           9        9              
  Lines         570      581      +11     
==========================================
+ Hits          405      411       +6     
- Misses        143      146       +3     
- Partials       22       24       +2     
Impacted Files Coverage Δ
analyzer.go 89.02% <66.66%> (-2.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d50c2b8...161133d. Read the comment docs.

analyzer.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @kirbyquerby!

@odeke-em odeke-em merged commit 74c0f4d into cosmos:master Jun 9, 2022
@kirbyquerby kirbyquerby deleted the nested-mods branch June 9, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants