chore: addressing formatting issues from PR feedback

cosmos · Aug 25, 2022 · d4c5b04 · d4c5b04
1 parent 7db37aa
commit d4c5b04
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 9 deletions.
diff --git a/modules/apps/27-interchain-accounts/controller/ibc_middleware.go b/modules/apps/27-interchain-accounts/controller/ibc_middleware.go
@@ -106,6 +106,7 @@ func (im IBCMiddleware) OnChanOpenAck(
 	if im.app != nil {
 		return im.app.OnChanOpenAck(ctx, portID, channelID, counterpartyChannelID, counterpartyVersion)
 	}
+
 	return nil
 }
 
@@ -164,6 +165,7 @@ func (im IBCMiddleware) OnAcknowledgementPacket(
 	if im.app != nil {
 		return im.app.OnAcknowledgementPacket(ctx, packet, acknowledgement, relayer)
 	}
+
 	return nil
 }
 
@@ -184,6 +186,7 @@ func (im IBCMiddleware) OnTimeoutPacket(
 	if im.app != nil {
 		return im.app.OnTimeoutPacket(ctx, packet, relayer)
 	}
+
 	return nil
 }
 

diff --git a/modules/apps/27-interchain-accounts/controller/ibc_middleware_test.go b/modules/apps/27-interchain-accounts/controller/ibc_middleware_test.go
@@ -121,8 +121,10 @@ func SetupICAPath(path *ibctesting.Path, owner string) error {
 }
 
 func (suite *InterchainAccountsTestSuite) TestOnChanOpenInit() {
-	var channel *channeltypes.Channel
-	var isNilApp bool
+	var (
+		channel  *channeltypes.Channel
+		isNilApp bool
+	)
 
 	testCases := []struct {
 		name     string
@@ -176,7 +178,6 @@ func (suite *InterchainAccountsTestSuite) TestOnChanOpenInit() {
 
 		suite.Run(tc.name, func() {
 			suite.SetupTest() // reset
-
 			isNilApp = false
 
 			path := NewICAPath(suite.chainA, suite.chainB)
@@ -284,8 +285,10 @@ func (suite *InterchainAccountsTestSuite) TestChanOpenTry() {
 }
 
 func (suite *InterchainAccountsTestSuite) TestOnChanOpenAck() {
-	var path *ibctesting.Path
-	var isNilApp bool
+	var (
+		path     *ibctesting.Path
+		isNilApp bool
+	)
 
 	testCases := []struct {
 		name     string
@@ -326,6 +329,7 @@ func (suite *InterchainAccountsTestSuite) TestOnChanOpenAck() {
 
 		suite.Run(tc.name, func() {
 			suite.SetupTest() // reset
+			isNilApp = false
 
 			path = NewICAPath(suite.chainA, suite.chainB)
 			suite.coordinator.SetupConnections(path)
@@ -520,8 +524,10 @@ func (suite *InterchainAccountsTestSuite) TestOnRecvPacket() {
 }
 
 func (suite *InterchainAccountsTestSuite) TestOnAcknowledgementPacket() {
-	var path *ibctesting.Path
-	var isNilApp bool
+	var (
+		path     *ibctesting.Path
+		isNilApp bool
+	)
 
 	testCases := []struct {
 		msg      string
@@ -600,8 +606,10 @@ func (suite *InterchainAccountsTestSuite) TestOnAcknowledgementPacket() {
 }
 
 func (suite *InterchainAccountsTestSuite) TestOnTimeoutPacket() {
-	var path *ibctesting.Path
-	var isNilApp bool
+	var (
+		path     *ibctesting.Path
+		isNilApp bool
+	)
 
 	testCases := []struct {
 		msg      string
@@ -637,6 +645,7 @@ func (suite *InterchainAccountsTestSuite) TestOnTimeoutPacket() {
 	for _, tc := range testCases {
 		suite.Run(tc.msg, func() {
 			suite.SetupTest() // reset
+			isNilApp = false
 
 			path = NewICAPath(suite.chainA, suite.chainB)
 			suite.coordinator.SetupConnections(path)