Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Audit Findings #178

Closed
3 tasks
colin-axner opened this issue May 18, 2021 · 0 comments · Fixed by #182
Closed
3 tasks

Upgrade Audit Findings #178

colin-axner opened this issue May 18, 2021 · 0 comments · Fixed by #182
Labels
good first issue Good for newcomers nice-to-have type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@colin-axner
Copy link
Contributor

Summary

The upgrade proposal ValidateBasic can remove the plan.Height <= 0 check, it is redundant

We can remove the IsExpired check in the 07-tendermint CheckAndUpgrade function, the status is checked in 02-client

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added nice-to-have type: code hygiene Clean up code but without changing functionality or interfaces good first issue Good for newcomers labels May 18, 2021
This was referenced May 20, 2021
Merged
Merged
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@ntsanov
time.Sleep removal from tests (cosmos#178)
08d9cd2 
* Added WaitGroup triggered on DeliverTx
* Replaced time.Sleep with Mempool.TxsAvailable()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers nice-to-have type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove duplicate checks in upgrade logic cosmos/ibc-go
1 participant
@colin-axner