Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No-op on redundant relay messages #245

Closed
3 tasks
colin-axner opened this issue Jul 7, 2021 · 0 comments · Fixed by #268
Closed
3 tasks

No-op on redundant relay messages #245

colin-axner opened this issue Jul 7, 2021 · 0 comments · Fixed by #268
Assignees
@colin-axner
Milestone
2.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

Instead of returning an error, we should do a no-op on relay messages which have already been relayed. This will prevent relay transactions with multi messages from failing due to one redundant message

We already have error codes for indicating a redundant message, we should simply return early here and ensure no state changes have occurred

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

perform a no-op on redundant relay messages cosmos/ibc-go
1 participant
@colin-axner