Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PacketAcknowledgements to take in packet commitments for filtering #370

Closed
3 tasks
colin-axner opened this issue Sep 2, 2021 · 2 comments · Fixed by #375
Closed
3 tasks

Allow PacketAcknowledgements to take in packet commitments for filtering #370

colin-axner opened this issue Sep 2, 2021 · 2 comments · Fixed by #375
Assignees
Milestone

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Sep 2, 2021

Summary

UnreceivedAcknowledgements currently takes in a list of acknowledgements and checks to see if the packet commitment still exists. The list of acknowledgements is obtained via a gRPC which returns all existing acknowledgements (even if the have been acknowledged on the sending chain). That gRPC should take in an optional list of packet commitments and only return acknowledgements for that list of packet commitments.

Problem Definition

The issue is acknowledgements live forever so it isn't sustainable to expect a relayer to be able to query for all ack sequences. Currently such a query returns ~64k sequences

Proposal

Add an additional field to the QueryPacketAcknowledgementsRequest which takes in a list of packet commitments. For each packet commitment, if the acknowledgement has been written, that sequence should be added to the array returned in the QueryPacketAcknowledgementsResponse


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner changed the title UnreceivedAcks should take in packet commitment sequences not a list of acknowledgements Allow PacketAcknowledgements to take in packet commitments for filtering Sep 2, 2021
@damiannolan damiannolan self-assigned this Sep 2, 2021
@damiannolan
Copy link
Contributor

@colin-axner This should remain backwards compatible right? If no commitments are included in the req, all should be added to the returned array as it works today, correct?

@colin-axner
Copy link
Contributor Author

@colin-axner This should remain backwards compatible right? If no commitments are included in the req, all should be added to the returned array as it works today, correct?

yup!

@crodriguezvega crodriguezvega added this to the 1.2.0 milestone Sep 17, 2021
faddat pushed a commit to notional-labs/ibc-go that referenced this issue Mar 1, 2022
* fix typo

* remove dash
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants