docs: add missing args to NewKeeper in integration docs (backport #1038) #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
## Description This add some missing arguments to `ibckeeper.NewKeeper` and `ibctransferkeeper.NewKeeper` in integration docs --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing) - [x] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit f71a505)
mergify
bot
requested review from
colin-axner,
fedekunze and
AdityaSripal
as code owners
colin-axner
approved these changes
Mar 3, 2022
CosmosCar
pushed a commit
to caelus-labs/ibc-go
that referenced
this pull request
Nov 6, 2023
…0.10.0 (cosmos#1051) Bumps [github.com/multiformats/go-multiaddr](https://github.com/multiformats/go-multiaddr) from 0.9.0 to 0.10.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/multiformats/go-multiaddr/releases">github.com/multiformats/go-multiaddr's releases</a>.</em></p> <blockquote> <h2>v0.10.0</h2> <h2>What's Changed</h2> <ul> <li>manet: add function to test if address is NAT64 IPv4 converted IPv6 address by <a href="https://github.com/sukunrt"><code>@sukunrt</code></a> in <a href="https://redirect.github.com/multiformats/go-multiaddr/pull/202">multiformats/go-multiaddr#202</a></li> <li>add a Unique function by <a href="https://github.com/marten-seemann"><code>@marten-seemann</code></a> in <a href="https://redirect.github.com/multiformats/go-multiaddr/pull/203">multiformats/go-multiaddr#203</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/sukunrt"><code>@sukunrt</code></a> made their first contribution in <a href="https://redirect.github.com/multiformats/go-multiaddr/pull/202">multiformats/go-multiaddr#202</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/multiformats/go-multiaddr/compare/v0.9.0...v0.10.0">https://github.com/multiformats/go-multiaddr/compare/v0.9.0...v0.10.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/multiformats/go-multiaddr/commit/e9b02fcdc16778f48fc978ff084b134ad4cb158e"><code>e9b02fc</code></a> release v0.10.0 (<a href="https://redirect.github.com/multiformats/go-multiaddr/issues/204">#204</a>)</li> <li><a href="https://github.com/multiformats/go-multiaddr/commit/589abd3f246eda6bc5aa9cb3b17ed390e17e7616"><code>589abd3</code></a> add a Unique function (<a href="https://redirect.github.com/multiformats/go-multiaddr/issues/203">#203</a>)</li> <li><a href="https://github.com/multiformats/go-multiaddr/commit/c9dc72e50d1ab8578ba9874dae8da17d1b37cbee"><code>c9dc72e</code></a> manet: add function to test if address is NAT64 IPv4 converted IPv6 address (...</li> <li><a href="https://github.com/multiformats/go-multiaddr/commit/44887f8026c48e752306db1b763c6e1c55fff0e7"><code>44887f8</code></a> sync: update CI config files (<a href="https://redirect.github.com/multiformats/go-multiaddr/issues/190">#190</a>)</li> <li>See full diff in <a href="https://github.com/multiformats/go-multiaddr/compare/v0.9.0...v0.10.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1038 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com