Code

[FEAT] ICS20-V2 Path Forwarding#6693

Code

Merged

crodriguezvega merged 162 commits intomaincosmos/ibc-go:mainfrom feat/ics20-v2-path-forwardingcosmos/ibc-go:feat/ics20-v2-path-forwardingCopy head branch name to clipboardJun 28, 2024

+4,396-424

Commits

Commits on Apr 8, 2024

• Adding proto files for ics20-v2 (#6110)

  Show description for c07bca9
  chatton

  authored
  c07bca9

Commits on Apr 9, 2024

• update amount -> string (#6120)

  charleenfei

  authored
  e66bd89

• Update MsgTransfer to accept sdk.Coins instead of sdk.Coin (#6113)

  chatton

  authored
  034f472

Commits on Apr 15, 2024

• fix: allow base denom with trailing slash (#6148)

  crodriguezvega

  authored
  4cc6a85

Commits on Apr 16, 2024

• imp: add CurrentVersion, EscrowVersion (#6160)

  Show description for 71f830c
  charleenfei

  authored
  71f830c

• chore: add function for converting packet data from v1 to v3 (#6116)

  Show description for 28ff9b6
  

  chatton

  and

  charleenfei

  authored
  28ff9b6

Commits on Apr 22, 2024

• chore: implement required FungibleTokenPacketData v3 interface methods (#6126)

  charleenfei

  authored
  4e55137

Commits on Apr 29, 2024

• imp: getMultiDenomFungibleTokenPacketDatato be used in packet unmarshalling/conversion (#6226)

  Show description for ca056cf
  

  3 peopleauthored
  ca056cf

Commits on May 6, 2024

• chore: implement version checking for channel handshake application callbacks (#6175)

  Show description for 147cf17
  

  charleenfei

  and

  crodriguezvega

  authored
  147cf17

• imp: update transfer authz implementation to account for multi denom transfers (#6252)

  Show description for 9bbfa1a
  

  charleenfei

  and

  crodriguezvega

  authored
  9bbfa1a

Commits on May 10, 2024

• ics20-v2: backwards compatibility for transfer rpc and packet callbacks (#6189)

  Show description for 4f57916
  

  3 peopleauthored
  4f57916

• add v3 packet proto

  sangier

  committed
  e04047e

• fix protos

  sangier

  committed
  c73d5f6

• fixes

  sangier

  committed
  03cc2e5

• test fixes

  sangier

  committed
  65f4476

Commits on May 13, 2024

• add forwardPath keys and memo check in sendTransfer

  sangier

  committed
  db85a29

• wip onRecvPacket logic

  sangier

  committed
  999ed80

• minor fixes

  sangier

  committed
  be72180

Commits on May 14, 2024

• changes to transfer tx CLI to support multiple denoms

  crodriguezvega

  committed
  4c333c5

• import renaming

  crodriguezvega

  committed
  0478cb9

• onRecv logic completed

  sangier

  committed
  37f5b5e

• add revertInFlights function

  sangier

  committed
  3fd3345

• add onAck && onTimeout logic

  sangier

  committed
  24e2407

• fix interchain accounts test

  crodriguezvega

  committed
  7858528

• basic unit test for path forwarding

  crodriguezvega

  committed
  55d7bf9

Commits on May 15, 2024

• fix test unsuccessful refund from source

  sangier

  committed
  1a95262

• wip test fix

  sangier

  committed
  44e15cb

Commits on May 16, 2024

• fix mbt test - need more investigation

  sangier

  committed
  334d5a9

• revert test fix

  sangier

  committed
  7466b19

• add assertions

  sangier

  committed
  5c46d79

• add support for async ack

  sangier

  committed
  99e6b0a

• wip test forwarding happy path

  sangier

  committed
  a114af6

Commits on May 17, 2024

• icsv20(path forwarding): use nil as default forwarding path when not set, use sequence in key to store forwarded packet (#6325)

  Show description for d800caa
  crodriguezvega

  authored
  d800caa

• add forwarding happy path tests

  sangier

  committed
  dd873a1

Commits on May 20, 2024

• Merge branch 'feat/ics20-v2' into stefano/carlos/ics20-v2-forwarding-poc

  sangier

  authored
  a292a3f

• fix merge

  sangier

  committed
  e25ba0c

Commits on May 21, 2024

• Use type with V2 suffix for package data (#6330)

  chatton

  authored
  f39d173

• Adding additional comments and changing version variable names (#6345)

  chatton

  authored
  9b39944

• Merge branch 'main' into merge-main

  chatton

  committed
  06ca9a5

• chore: correctly claim capability

  chatton

  committed
  7897ef3

• lint

  colin-axner

  committed
  786a4f1

• Merge pull request #6346 from cosmos/merge-main

  Show description for 5747756
  DimitrisJim

  authored
  5747756

Commits on May 22, 2024

• Merge branch 'main' into feat/ics20-v2

  chatton

  authored
  7e2e6df

• imp: change ics20 events to emit token set (#6348)

  Show description for a84b0e7
  

  colin-axner

  and

  DimitrisJim

  authored
  a84b0e7

• imp: check length tokens array against maximum allowed (#6349)

  Show description for 43877df
  

  crodriguezvega

  and

  colin-axner

  authored
  43877df

• Modify UnmarshalPacketData interface to allow additional args (#6341)

  Show description for 8eae033
  DimitrisJim

  authored
  8eae033

Commits on May 23, 2024

• Refactor packet data unmarshalling to use specific version (#6354)

  Show description for dbcff45
  

  3 peopleauthored
  dbcff45

• Merge branch 'main' into merge-main-2

  chatton

  committed
  bb69698

• chore: fixing tests

  chatton

  committed
  f19a145

• Merge pull request #6359 from cosmos/merge-main-2

  Show description for 8f86dda
  chatton

  authored
  8f86dda

• imp: self review comments for ics20-v2 (#6360)

  Show description for d4b06c8
  colin-axner

  authored
  d4b06c8

• imp: self review on ics20-v2 part 2 (#6364)

  Show description for a9391a4
  

  colin-axner

  and

  chatton

  authored
  a9391a4

• chore: move functions from internal/denom back to trace.go (#6368)

  Show description for 575403e
  DimitrisJim

  authored
  575403e

• imp: ics20 v2 self review part 3 (#6373)

  Show description for 50ccd94
  colin-axner

  authored
  50ccd94

• chore: remove duplicate test case

  colin-axner

  committed
  87eb32e

• chore: address minor nits (#6374)

  DimitrisJim

  authored
  e8b9d5a

• Merge branch 'feat/ics20-v2' into stefano/carlos/ics20-v2-forwarding-poc

  Show description for 57aab01
  crodriguezvega

  committed
  57aab01

Commits on May 26, 2024

• fix lint warning, add extra godocs, and some other small fixes and cleanup

  crodriguezvega

  committed
  2519593

Commits on May 27, 2024

• Merge branch 'main' into stefano/carlos/ics20-v2-forwarding-poc

  Show description for 3bf6c04
  crodriguezvega

  committed
  3bf6c04

• fix finalReceiver address bug

  sangier

  committed
  64c2fc4

• wip - ack test scenario5

  sangier

  committed
  7cd7260

Commits on May 28, 2024

• add FungibleTokenPacketDataV2 test for ValidateBasic (#6398)

  hastur199

  authored
  6673e74

• fix linter complaints

  crodriguezvega

  committed
  550eeef

• add test - currently faling on middle hop revert

  sangier

  committed
  4c54a88

• add test comments

  sangier

  committed
  debc4cb

• fixes

  sangier

  committed
  e50fa40

Commits on May 31, 2024

• Merge branch 'main' into stefano/carlos/ics20-v2-forwarding-poc

  Show description for 6d87d95
  crodriguezvega

  committed
  6d87d95

• retrieve channel capability only if there is a previous packet in store

  crodriguezvega

  committed
  7c8f516

Commits on Jun 7, 2024

• Merge branch 'main' into stefano/carlos/ics20-v2-forwarding-poc

  Show description for feb7b01
  crodriguezvega

  committed
  feb7b01

Commits on Jun 9, 2024

• Merge branch 'main' into stefano/carlos/ics20-v2-forwarding-poc

  Show description for 6fd1773
  crodriguezvega

  committed
  6fd1773

• add missing parameter

  crodriguezvega

  committed
  efcfa5d

Commits on Jun 10, 2024

• fix: e2e build failures.

  DimitrisJim

  committed
  21dbb37

Commits on Jun 11, 2024

• Use Transfer instead of sendTransfer when forwarding. (#6564)

  Show description for 70d7a29
  DimitrisJim

  authored
  70d7a29

• lint: fix linter issues.

  DimitrisJim

  committed
  465b16c

• tests(transfer): move forwarding tests to separate file. (#6568)

  DimitrisJim

  authored
  ec472cf

Commits on Jun 12, 2024

• chore: rename ForwardingInfo to Forwarding

  damiannolan

  committed
  e483b9a

• Revert "chore: rename ForwardingInfo to Forwarding"

  Show description for 0c9f368
  damiannolan

  committed
  0c9f368

• nit(transfer): Mark hops as non nullable. (#6566)

  Show description for 413b7c1
  DimitrisJim

  authored
  413b7c1

• feat(transfer): add forwarding info validation to token packet (#6571)

  Show description for ae2046a
  gjermundgaraba

  authored
  ae2046a

Commits on Jun 13, 2024

• feat(transfer): add validation for forwarding info in msg transfer validate basic (#6583)

  gjermundgaraba

  authored
  ba7c4a8

• Fix and simplify reverts of forwarding state (#6574)

  Show description for 6b3b5aa
  srdtrk

  authored
  6b3b5aa

• chore: rename ForwardingInfo to Forwarding (#6576)

  Show description for 5070e50
  damiannolan

  authored
  5070e50

• Refactor packet forward functions (#6575)

  chatton

  authored
  d874b54

• Merge branch 'main' into feat/ics20-v2-path-forwarding

  Show description for a8cd302
  crodriguezvega

  committed
  a8cd302

• feat(transfer): validate forwarding memo in transfer authorization (#6591)

  gjermundgaraba

  authored
  fbb9cd8

Commits on Jun 14, 2024

• Add func convert token to coin ibc (#6584)

  Show description for c4987a7
  

  3 peopleauthored
  c4987a7

• transfer: Disallow a forwarding object specified with zero hops and a memo (#6599)

  Show description for a90b671
  

  3 peopleauthored
  a90b671

• feat(transfer): move async decision and handling to the ibc module onrecv callback (#6592)

  Show description for c348732
  

  6 peopleauthored
  c348732

Commits on Jun 16, 2024

• Merge branch 'main' into feat/ics20-v2-path-forwarding

  crodriguezvega

  committed
  789b09b

Commits on Jun 17, 2024

• chore: use NewForwarding instead of direct init (#6605)

  gjermundgaraba

  authored
  c00ddd9

• Reduce max forwarding to 16 (#6610)

  DimitrisJim

  authored
  fc6c111

• feat(transfer): use single byte ack for successful forward (#6604)

  Show description for 72714b3
  

  gjermundgaraba

  and

  bznein

  authored
  72714b3

Commits on Jun 18, 2024

• chore(transfer/cli): add forwarding flag to tx cli (#6609)

  Show description for c546f69
  

  DimitrisJim

  and

  crodriguezvega

  authored
  c546f69

• chore(transfer): make Forwarding non-null (#6618)

  Show description for 60a6b99
  DimitrisJim

  authored
  60a6b99

• chore: restructure functions with logical ordering (#6638)

  damiannolan

  authored
  dc47641

Commits on Jun 19, 2024

• test: Add tests for OnTimeoutPacket when middle chain times out packet (#6596)

  Show description for 832b1bd
  

  bznein

  and

  crodriguezvega

  authored
  832b1bd

• feat(transfer): add ShouldBeForwarded convenience method to msg transfer (#6595)

  Show description for 360b2f8
  

  gjermundgaraba

  and

  crodriguezvega

  authored
  360b2f8

• disallow timeout height usage when forwarding packets (#6641)

  Show description for 84c7c33
  

  crodriguezvega

  and

  colin-axner

  authored
  84c7c33

• nit: make set forwarded packet unexported (#6637)

  Show description for 007dee1
  

  3 peopleauthored
  007dee1

• feat(transfer): use registered error code for error acks in token forwarding (#6648)

  Show description for 14d5486
  gjermundgaraba

  authored
  14d5486

Commits on Jun 20, 2024

• chore(transfer): emit forwarding information in events. (#6647)

  Show description for a28a549
  DimitrisJim

  authored
  a28a549

• Merge branch 'main' into gjermund/merge-main-to-feat-ics20-v2-path-fowarding

  gjermundgaraba

  committed
  d6db0c5

• Fix e2e test

  gjermundgaraba

  committed
  64bc502

• Merge pull request #6662 from cosmos/gjermund/merge-main-to-feat-ics20-v2-path-fowarding

  Show description for 1ca1f2f
  chatton

  authored
  1ca1f2f

• Refactor forwarding messages for Transfer and Packet (#6655)

  Show description for 87d1f91
  

  DimitrisJim

  and

  crodriguezvega

  authored
  87d1f91

Commits on Jun 21, 2024

• feat: allow authz granters to specify forwarding info for token transfer (#6661)

  Show description for ef6d22f
  bznein

  authored
  ef6d22f

• feat: delete forwarded packet when it is not needed anymore (#6621)

  Show description for da2f9f6
  

  3 peopleauthored
  da2f9f6

• test(transfer): forwarding acknowledgment errors in middle hop (#6659)

  Show description for e68143b
  

  gjermundgaraba

  and

  crodriguezvega

  authored
  e68143b

• test(transfer): last chain in forwarding packet is ICS20 v1 (#6622)

  Show description for 6619821
  

  gjermundgaraba

  and

  bznein

  authored
  6619821

Commits on Jun 24, 2024

• refactor: rename SetupPath to SetupPaths (#6674)

  gjermundgaraba

  authored
  43eceed

• chore: add flag for unwind in transfer cli (#6680)

  Show description for aa860ac
  

  neitdung

  and

  crodriguezvega

  authored
  aa860ac

• feat: impl check reject transfer if len(hops) > 0 and ics20-1 (#6675)

  Show description for 2b4d24b
  

  3 peopleauthored
  2b4d24b

Commits on Jun 25, 2024

• feat(transfer): add unwinding ability (#6656)

  Show description for 59e3df7
  

  3 peopleauthored
  59e3df7

• Merge branch 'main' into feat/ics20-v2-path-forwarding

  chatton

  authored
  e3ffcff

• fix typo

  crodriguezvega

  committed
  9c5ae03

• remove unnecessary wrapping of function

  crodriguezvega

  committed
  c2a6bc6

• Revert "remove unnecessary wrapping of function"

  Show description for c3ccbfc
  crodriguezvega

  committed
  c3ccbfc

• fix usage of function

  crodriguezvega

  committed
  5345776

• (chore) replace reflect.DeepEqual with slices.Equal (#6697)

  Show description for 74088ba
  bznein

  authored
  74088ba

• chore: comment hop slicing for clarity (#6702)

  Show description for 272c12b
  

  gjermundgaraba

  and

  crodriguezvega

  authored
  272c12b

Commits on Jun 26, 2024

• chore: cleanup forwarding tests (#6691)

  Show description for 4349a1d
  

  3 peopleauthored
  4349a1d

• chore: pull out hop validation and consolidate for transfer+packet (#6695)

  Show description for 24cd07f
  

  gjermundgaraba

  and

  crodriguezvega

  authored
  24cd07f

• Merge branch 'main' into feat/ics20-v2-path-forwarding

  chatton

  authored
  dca8c42

• Remove unwind field in authz (#6701)

  Show description for 37d7335
  

  chatton

  and

  crodriguezvega

  authored
  37d7335

• chore: add packet data validation back (#6704)

  chatton

  authored
  6e1a082

• (chore) Refactor code around forwarding validation (#6706)

  Show description for 8f9691f
  

  3 peopleauthored
  8f9691f

• use setupForwardingPaths in test

  crodriguezvega

  committed
  c505243

• feat(transfer): allow non-cosmos-sdk AccAddress in final receiver for forwarded packets (#6709)

  Show description for d715455
  gjermundgaraba

  authored
  d715455

• chore: pass only hops to sendTransfer + events rename (#6703)

  Show description for 4e61ea9
  

  gjermundgaraba

  and

  crodriguezvega

  authored
  4e61ea9

• test: forwarding test that verifies forwarded memo (#6707)

  Show description for 3e2a5fa
  gjermundgaraba

  authored
  3e2a5fa

• chore: update godoc for relay forwarding tests

  gjermundgaraba

  committed
  5ea9d79

• chore: use module account instead of custom forward address (#6688)

  Show description for 100ccc7
  gjermundgaraba

  authored
  100ccc7

• chore: replace continue with if/else (#6700)

  Show description for 13d3ac6
  

  crodriguezvega

  and

  bznein

  authored
  13d3ac6

Commits on Jun 27, 2024

• Merge branch 'main' into feat/ics20-v2-path-forwarding

  Show description for b6d77d7
  crodriguezvega

  committed
  b6d77d7

• add changelog

  crodriguezvega

  committed
  4d19be1

• add test for invalid receiver address

  crodriguezvega

  committed
  2838aef

• Update CHANGELOG.md

  crodriguezvega

  authored
  7afb7f6

• Update CHANGELOG.md

  crodriguezvega

  authored
  0221c6b

• make getForwardedPacket private

  crodriguezvega

  committed
  cc46a63

• remove auxiliary burn coins function

  crodriguezvega

  committed
  e67aeaf

• nit: rename func method recv args in types/forwarding.go

  damiannolan

  committed
  966a644

• chore: rename ShouldBeForwarded to HasFowarding

  damiannolan

  committed
  e92e086

• e2e: remove template test for three chain setup.

  DimitrisJim

  committed
  6ea614f

• nit: no generics silly

  DimitrisJim

  committed
  18d0567

• nit: add clarifying comment to validate basic call on msg.

  DimitrisJim

  committed
  1b7214d

• nit: remove unused key.

  DimitrisJim

  committed
  1f5e61f

• nit: clean up cli help text.

  DimitrisJim

  committed
  0a78bde

• nit: don't export is blocked address helper.

  DimitrisJim

  committed
  07036a9

• nit: docustring for e2e test and helper.

  DimitrisJim

  committed
  1442874

• nit: improve documentation for transfer's OnRecv callback.

  Show description for 25c73c4
  

  DimitrisJim

  and

  damiannolan

  authored
  25c73c4

• Apply suggestions from code review

  Show description for baf3fd3
  

  crodriguezvega

  and

  AdityaSripal

  authored
  baf3fd3

• chore: remove unused function

  crodriguezvega

  committed
  7d2a881

• perf: allocate slice to length of packet data tokens

  crodriguezvega

  committed
  4ea36c2

• Merge branch 'main' into feat/ics20-v2-path-forwarding

  crodriguezvega

  authored
  0a28e9b

• chore(transfer/authz): wrapf unauthorized forwarding hops

  damiannolan

  committed
  7411f2d

• lint

  crodriguezvega

  committed
  199c14a

• Update modules/apps/transfer/types/forwarding.go

  Show description for c7af85a
  

  crodriguezvega

  and

  DimitrisJim

  authored
  c7af85a

• Merge branch 'main' into feat/ics20-v2-path-forwarding

  crodriguezvega

  authored
  25239a2

• Preallocate slice but keep len==0 (#6725)

  bznein

  authored
  90d57db

• imp: validate allowed forwarding hops

  crodriguezvega

  committed
  e310e27

• test: unwind fails in Transfer rpc

  crodriguezvega

  committed
  f28e937

Commits on Jun 28, 2024

• Merge branch 'main' into feat/ics20-v2-path-forwarding

  crodriguezvega

  authored
  50daed0