Fix optimistic sequence bug

cosmos · Nov 2, 2020 · 8a92af0 · 8a92af0
1 parent eb31a56
commit 8a92af0
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/spec/ics-004-channel-and-packet-semantics/README.md b/spec/ics-004-channel-and-packet-semantics/README.md
@@ -354,9 +354,12 @@ function chanOpenTry(
                          counterpartyChannelIdentifier, connectionHops, version}
     provableStore.set(channelPath(portIdentifier, channelIdentifier), channel)
     channelCapability = newCapability(channelCapabilityPath(portIdentifier, channelIdentifier))
-    provableStore.set(nextSequenceSendPath(portIdentifier, channelIdentifier), 1)
-    provableStore.set(nextSequenceRecvPath(portIdentifier, channelIdentifier), 1)
-    provableStore.set(nextSequenceAckPath(portIdentifier, channelIdentifier), 1)
+    // only reset sequences if the previous channel didn't exist, else we might overwrite optimistically-sent packets
+    if (previous === null) {
+      provableStore.set(nextSequenceSendPath(portIdentifier, channelIdentifier), 1)
+      provableStore.set(nextSequenceRecvPath(portIdentifier, channelIdentifier), 1)
+      provableStore.set(nextSequenceAckPath(portIdentifier, channelIdentifier), 1)
+    }
     return channelCapability
 }
 ```