Milestone: # Blog-app Views #6
Conversation
There was a problem hiding this comment.
STATUS: CHANGES REQUIRED ♻️
Hi @cosywasswa👋,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
To Highlight 🎉
- Good job with views. ✔️
- Gitflow is followed. ✔️
- Professional README file. ✔️
- No linter errors. ✔️
- PR has a good title and summary. ✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
app/views/users/show.html.erb
Outdated
| <% @posts.each do |post| %> | ||
| <div class="post-details"> | ||
| <h2>Post #<%= post.id %></h2> | ||
| <h3><%= post.text %></h3> |
There was a problem hiding this comment.
- Please use the method
recent_postsavailable in theusermodel and loop through it instead of looping through all posts. Also, theposts #should be a link to the post-show page.
app/views/posts/index.html.erb
Outdated
|
|
||
| <div class="comment-cont"> | ||
| <% post.comments.each do |comment| %> | ||
| <p><%= @user.name %>: <%= comment.text %> <%= comment.id %></p> | ||
| <% end %> | ||
| </div> |
There was a problem hiding this comment.
- Please use the method
recent_commentsavailable in thepostmodel and loop through it instead of looping through all comments.
There was a problem hiding this comment.
Approved 👏
Hi @cosywasswa 👋,
Well done implementing the requested changes 👏
Highlights 🚀 ✔️ ✔️
- The repo looks professional.:heavy_check_mark:
- Git/GitHub flow best practices have been followed:heavy_check_mark:
- You have descriptive PR:heavy_check_mark:
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag @bienvenuushindi in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
👇 In this pull request, I performed the following tasks.