This repository has been archived by the owner on Dec 13, 2019. It is now read-only.
[Wallet-UI] ERC20 Token Support #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spersico I think something went wrong while rebasing this PR, the commit history looks weird. Can you take a look? |
spersico
changed the title
spersico
requested review from
cf19drofxots,
ebryn,
ldct,
briarsweetbriar and
snario
as code owners
spersico
force-pushed
the
wallet-ui/erc20-support
branch
from
8e03f92 to
5e32dca
Compare
joelalejandro
approved these changes
Aug 8, 2019
joelalejandro
suggested changes
Aug 9, 2019
packages/wallet-ui/src/pages/account-deposit/AccountDeposit.tsx
Outdated
Show resolved
Hide resolved
joelalejandro
suggested changes
Aug 12, 2019
joelalejandro
approved these changes
Aug 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR, when merged will add support for withdraw and deposit transactions inside the wallet.
The necessary middleware modifications have been added in the MM integration branch.
There are some details to polish, but deposits and withdraws behave like ETH now, and the balance component now shows the current state of the balance for all currencies.
Related issues
closes #1955