Add ability to configure defaults #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-wall
force-pushed
the
feature-config-except
branch
from
689118c to
982b371
Compare
|
@p-wall This is super, and works well! Should we add a README note about this feature, to teach it to people scanning the README? |
scudco
reviewed
May 1, 2021
There was a problem hiding this comment.
Thanks for submitting this with tests @p-wall! This will be a good contribution :)
I have one request around how values are accessed, and I would second @olleolleolle's suggestion to add information to the README.
|
Updated to use fetch and added a section to the README :) |
henrik
reviewed
May 4, 2021
Co-authored-by: Henrik Nyh <[email protected]>
|
@scudco Cool, is this like ready to go? |
|
I'll get a release out on rubygems in the next couple days. Thanks @p-wall and @olleolleolle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows configuring defaults, for example excluding certain countries app-wide.
Closes #183