Allow option to preserve the sort order as inputted in the only
array of countries
#202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@scudco
I've been thinking about #194 , and came up with another possibility:
That is, adding a
sort_provided
option that controls if the list of countries is locale-sorted or we use the order of theonly
andpriority_countries
array.The default behaviour is unchanged from the current version, this just adds the new option to allow preserving the sort order as inputted, and is a pretty small code change.This adds the new option and is a small change, but it changes the default behaviour for
priority_countries
to sorting the list, so that bothpriority_countries
andonly
have the same sorting behaviour and defaults, so it does include a breaking change.