Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Rails 7.1 after recent Form Options helper changes #219

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

ron-shinall
Copy link
Contributor

A recent Rails Edge commit (rails/rails@77f3fc1) moves the Form Options helper into select rendering classes. This is a breaking change for country_select.

This PR adds support for the changes, and it has been tested with all of the versions of Rails that country_select supports.

If the approach I've used is not what you prefer, perhaps it will spark some additional ideas for addressing the issue.

@scudco
Copy link
Collaborator

scudco commented Jul 2, 2023

@ron-shinall can you add 7.1 to the Github test workflow's gemfile matrix at .github/workflows/test.yml?

@ron-shinall
Copy link
Contributor Author

@scudco sorry I missed that! I've added it and all checks have passed.

@scudco scudco requested a review from pmor July 10, 2023 12:41
@pmor pmor merged commit 2ee592b into countries:master Jul 10, 2023
@swistaczek
Copy link

Hey @pmor, are there any chances you will be able to release an updated gem soon :)?

@pmor
Copy link
Member

pmor commented Jul 26, 2023

I'm traveling, but next week I should be able to take care of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants