Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): +reset page on predicate change, +unit tests #3538

Merged

Conversation

FelixBlaisThon
Copy link
Contributor

Proposed Changes

https://coveord.atlassian.net/browse/ADUI-9179

When changing predicates, it sets the state to page: 0 the same way changing filter does.

Potential Breaking Changes

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • README.md is adjusted to reflect the proposed changes (if relevant)

@FelixBlaisThon FelixBlaisThon requested review from a team, gdostie and aboissinot-coveo and removed request for a team September 6, 2023 17:04
@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
plasma-components-props-analyzer ✅ Ready (Inspect) Visit Preview Sep 6, 2023 5:05pm
plasma-mantine ✅ Ready (Inspect) Visit Preview Sep 6, 2023 5:05pm
plasma-react ✅ Ready (Inspect) Visit Preview Sep 6, 2023 5:05pm
plasma-react-icons ✅ Ready (Inspect) Visit Preview Sep 6, 2023 5:05pm
plasma-style ✅ Ready (Inspect) Visit Preview Sep 6, 2023 5:05pm
plasma-token ✅ Ready (Inspect) Visit Preview Sep 6, 2023 5:05pm
plasma-website ✅ Ready (Inspect) Visit Preview Sep 6, 2023 5:05pm

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Copy link
Collaborator

@gdostie gdostie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

@FelixBlaisThon FelixBlaisThon merged commit 0eb9910 into master Sep 6, 2023
@FelixBlaisThon FelixBlaisThon deleted the ADUI-9179-navigate-when-tablepredicate-changes branch September 6, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants