feat(mantine): add syncWithUrl option to table hook #3985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdostie
force-pushed
the
ADUI-10406-table-url-sync
branch
from
dce597f to
aa7402e
Compare
gdostie
commented
Dec 16, 2024
gdostie
force-pushed
the
ADUI-10406-table-url-sync
branch
2 times, most recently
from
14da387 to
97ee8f7
Compare
gdostie
commented
Dec 16, 2024
gdostie
force-pushed
the
ADUI-10406-table-url-sync
branch
5 times, most recently
from
791c5d0 to
1e2cfc4
Compare
gdostie
requested review from
GermainBergeron and
FelixBlaisThon
and removed request for
a team
gdostie
force-pushed
the
ADUI-10406-table-url-sync
branch
from
1e2cfc4 to
77c6f6c
Compare
GermainBergeron
approved these changes
Dec 19, 2024
packages/mantine/src/components/table/__tests__/TablePredicate.spec.tsx
Outdated
Show resolved
Hide resolved
packages/mantine/src/components/table/__tests__/TablePredicate.spec.tsx
Outdated
Show resolved
Hide resolved
|
Demo works too from what I've tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add
syncWithUrloption touseTablehook. When true, the table will sync its state with the url using search parameters.Potential Breaking Changes
Acceptance Criteria