Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to generate Contract::deployed regardless of whether there are networks #99

Closed
nlordell opened this issue Jan 3, 2020 · 0 comments · Fixed by #127
Closed

Option to generate Contract::deployed regardless of whether there are networks #99

nlordell opened this issue Jan 3, 2020 · 0 comments · Fixed by #127
Milestone
0.3.0

Comments

@nlordell
Copy link
Contributor

nlordell commented Jan 3, 2020

This makes things like running cargo test easier.
@nlordell nlordell changed the title Option to generate deployed regardless of whether there are networks Option to generate Contract::deployed regardless of whether there are networks Jan 3, 2020
@nlordell nlordell added this to the 0.3.0 milestone Jan 13, 2020
@nlordell nlordell mentioned this issue Jan 16, 2020
Merged
nlordell added a commit that referenced this issue Jan 16, 2020
@nlordell
Manual deployment address (#127)
30b724d 
Add ability to manually specify deployment addresses. This closes #99 and #100 .

This PR also adds unit tests in the code generation and derive libraries - so unit tests can be slowly added for code generation as future modification come in.

### Test Plan

Unit tests and new example.

### Commit History

* added ability to manually specify deployments

* started implementing derive macro parsing for new parameters

* builder parsing of deployments with tests

* added working deployments example

* added example to README

* remove commented code

* run deployments example in travis

* suggestions

* cargo fmt

* added error for duplicate deployments

* minor corrections to test Context

* remove duplicate comma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

Manual deployment address cowprotocol/ethcontract-rs
1 participant
@nlordell