Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flags] localStorage is used on Node, which throws an error #402

Closed
drazik opened this issue Apr 25, 2019 · 0 comments · Fixed by #403
Closed

[flags] localStorage is used on Node, which throws an error #402

drazik opened this issue Apr 25, 2019 · 0 comments · Fixed by #403
Labels
flags

Comments

@drazik
Copy link
Contributor

drazik commented Apr 25, 2019

The following error is thrown in the cozy-banks service using [email protected]:

localStorage is not defined

I don't have the time to fix it now so I'm just downgrading cozy-flags in Banks. I will look at it asap if nobody have the time before me.
@drazik drazik added the flags label Apr 25, 2019
drazik added a commit to cozy/cozy-banks that referenced this issue Apr 25, 2019
@drazik
fix: Downgrade cozy-flags to v1.5.9
0741426 
[email protected] seems to try to use `localStorage` on node, which
doesn't work. See cozy/cozy-libs#402
drazik added a commit to cozy/cozy-banks that referenced this issue Apr 25, 2019
@drazik
fix: Remove flag.connect calls
10cc9e3 
This is a feature from [email protected] which we downgraded due to
cozy/cozy-libs#402
drazik added a commit that referenced this issue Apr 26, 2019
@drazik
fix: Expose FlagSwitcher only in browser context
1e3f0be 
Exposing FlagSwitcher on node context was causing an error in Node
context because it's importing the flags browser implementation and
`localStorage` doesn't exist in this context.

Fixes #402
@drazik drazik mentioned this issue Apr 26, 2019
Merged
drazik added a commit that referenced this issue May 2, 2019
@drazik
fix: Expose FlagSwitcher only in browser context
4b6a5d9 
Exposing FlagSwitcher on node context was causing an error in Node
context because it's importing the flags browser implementation and
`localStorage` doesn't exist in this context.

Fixes #402
drazik added a commit that referenced this issue May 3, 2019
@drazik
fix: Expose FlagSwitcher only in browser context
2a4829b 
Exposing FlagSwitcher on node context was causing an error in Node
context because it's importing the flags browser implementation and
`localStorage` doesn't exist in this context.

Fixes #402
drazik added a commit that referenced this issue May 3, 2019
@drazik
fix: Expose FlagSwitcher only in browser context
03c8620 
Exposing FlagSwitcher on node context was causing an error in Node
context because it's importing the flags browser implementation and
`localStorage` doesn't exist in this context.

Fixes #402
drazik added a commit that referenced this issue May 3, 2019
@drazik
fix: Expose FlagSwitcher only in browser context
f2fafa7 
Exposing FlagSwitcher on node context was causing an error in Node
context because it's importing the flags browser implementation and
`localStorage` doesn't exist in this context.

Fixes #402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flags
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Expose FlagSwitcher only in browser context cozy/cozy-libs
1 participant
@drazik