Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Let torch ignore time settings #128

Closed
antonyburden opened this issue Mar 23, 2021 · 4 comments
Closed

[Feature Request] Let torch ignore time settings #128

antonyburden opened this issue Mar 23, 2021 · 4 comments
Labels
request New feature or request solved Solved, but not yet released.
Milestone

Comments

@antonyburden
Copy link

This may be a bug, but when the time settings dictate the LED's status settings are off, any TORCH command also fails.

I believe for both to be of use ANY torch command should over-ride/ignore the time settings.

My use is the torch comes on via GCODE and a photo is taken and pushed to my phone, works great unless time settings are activated and my photo is black during the small hours!

@github-actions github-actions bot added needs triage Issue needs manual triage (aka bot couldn't do it...) incomplete Issue is not complete, more info requested by the bot labels Mar 23, 2021
@github-actions
Copy link

Hi @antonyburden,

It looks like there is some information missing from this issue that is required to process it:

Please read this guide, especially the troubleshooting section.

If you have read this guide, please tick the box in your issue next to 'I have read the Get Help Guide'

* [x] I have read the Get Help Guide

If you didn't mean to ask for help, please make sure you used the right template - bugs and requests should have [Bug] and [Request] respectively in the title.

I'm just a bot 🤖, not a human being, so don't expect any replies from me :) Your ticket is read by humans too, I'm just not one of them.

@antonyburden antonyburden changed the title Torch should ignore time settings [Feature Request] / [Bug] Torch should ignore time settings Mar 23, 2021
@github-actions github-actions bot added needs review Yet to be reviewed potential bug Bug reported but yet to be analysed request New feature or request and removed incomplete Issue is not complete, more info requested by the bot labels Mar 23, 2021
@cp2004
Copy link
Owner

cp2004 commented Mar 23, 2021

This is a request, since it was intentionally designed that nothing on the LEDs shows when they are outside the active time. Maybe will sort out something for the next release that makes it work.

@cp2004 cp2004 removed needs review Yet to be reviewed needs triage Issue needs manual triage (aka bot couldn't do it...) potential bug Bug reported but yet to be analysed labels Mar 23, 2021
@cp2004 cp2004 added this to the 0.8.0 milestone Mar 23, 2021
@cp2004 cp2004 changed the title [Feature Request] / [Bug] Torch should ignore time settings [Feature Request] Let torch ignore time settings Mar 23, 2021
@github-actions github-actions bot added the needs review Yet to be reviewed label Mar 23, 2021
@cp2004 cp2004 removed the needs review Yet to be reviewed label Mar 23, 2021
@cp2004
Copy link
Owner

cp2004 commented Nov 15, 2021

🎉 Implemented and will be released with 0.8.0. There'll be a release candidate beforehand, switch to the 'Release Candidate' channel in the software update section to get notified when it is available.

@cp2004 cp2004 added the solved Solved, but not yet released. label Nov 15, 2021
cp2004 added a commit that referenced this issue Nov 15, 2021
This plugin is so highly configurable isn't it

Closes #128
@cp2004
Copy link
Owner

cp2004 commented Feb 4, 2022

0.8.0 has been released (finally...!)

@cp2004 cp2004 closed this as completed Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request New feature or request solved Solved, but not yet released.
Projects
None yet
Development

No branches or pull requests

2 participants