Fix broken images if octoprint is not at website's root #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessful bot triage
Make the URLs for the LED status icons relative, for them to work outside root (with Octoprint URLs like http://example.website/octoprint/ )
|
The URL : Before : After (sorry for the theme) : |
cp2004
approved these changes
Apr 29, 2021
|
Thanks! I remember looking at this at some point but had completely forgotten, it will be part of the next release 🙂. Please note however, this release may not be for some time as I have a lot to do at the moment. No problems I can see, thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pull request, so I hope I'm not making too much mistakes. I figured that images URLs are not working if octoprint is situated at http(s):///octoprint/. By making the URL relative with "./plugin/..." (like in other plugins), images work again.