Show provisional draft data in element chips/cards/tables #14975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonkelly
changed the title
…ms-1302-show-provisional-draft-data-in-element-chips-cards
…ms-1302-show-provisional-draft-data-in-element-chips-cards
…ms-1302-show-provisional-draft-data-in-element-chips-cards # Conflicts: # src/elements/NestedElementManager.php # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
…in-element-chips-cards # Conflicts: # src/elements/NestedElementManager.php # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
…in-element-chips-cards # Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
gcamacho079
requested changes
May 28, 2024
There was a problem hiding this comment.
This looks great, @brandonkelly! The only change I would suggest is:
- In the card view, it would be helpful to put the status badges in a
ul.
…in-element-chips-cards # Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
[ci skip]
|
Done! Thanks @gcamacho079 |
brandonkelly
deleted the
feature/cms-1302-show-provisional-draft-data-in-element-chips-cards
branch
|
This is a sneaky awesome update. Bravo! It's been fun seeing all of these detail polishing updates drop in the 5.2 release. Keep up the great work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an element has a provisional draft, its chips, cards, and index table data will now show the provisional draft’s data, as well as an “Edited” label.
When editing an element via a slideout, its chips, cards, and table data will automatically refresh to reflect the latest changes (including its “Edited” label).