default backup command and default charset #16762
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkelty
reviewed
Feb 24, 2025
| @@ -204,7 +204,7 @@ public function getDefaultBackupCommand(?array $ignoreTables = null): string | |||
| ->addArg('--dump-date') | |||
| ->addArg('--no-autocommit') | |||
| ->addArg('--routines') | |||
| ->addArg('--default-character-set=', Craft::$app->getConfig()->getDb()->charset) | |||
There was a problem hiding this comment.
Seems like ideally we'd want to make \craft\config\DbConfig::$charset protected and add setCharset so this code would work either way?
The only reason why the current method is \craft\config\DbConfig::charset and not \craft\config\DbConfig::setCharset is because of fluent config conventions. So, if we add it, one can just reference the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When getting the default backup command, use
getCharset()to get thedefault-character-setvalue so that for MySQLutf8is normalised toutf8mb4.Related issues
#16753