Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call to undefined method PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocNode::getRequireExtendsTagValues() #18

Closed
jonw-cogapp opened this issue Jan 11, 2024 · 2 comments
Closed

Call to undefined method PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocNode::getRequireExtendsTagValues() #18

jonw-cogapp opened this issue Jan 11, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jonw-cogapp
Copy link

Description

As a dependency of Rector, PHPStan 1.10.55 created a recent issue with rector 0.18.x, which was resolved in rector 0.19.0. However craftcms/rector requires rector ^0.18.4, so it seems there isn't an upgrade pathway to mitigate this error until craftcms/rector supports rector 0.19.x.

 [ERROR] Could not process "config/app.php" file, due to:                                                               
         "Call to undefined method PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocNode::getRequireExtendsTagValues()". On line:  
         330

Steps to reproduce

  1. composer require --dev rector/rector:^0.18
  2. Follow the instructions in the readme for including craftcms/rector
  3. Add a rector.php file using the given example
  4. vendor/bin/rector --dry-run

Additional info

  • Craft version: 4.6
  • PHP version: 8.2
@jonw-cogapp jonw-cogapp added the bug Something isn't working label Jan 11, 2024
@khalwat
Copy link
Contributor

khalwat commented Jan 28, 2024

Ran into this today...

khalwat added a commit to khalwat/rector that referenced this issue Jan 28, 2024
@khalwat
fix: Fix upstream issue in rector/rector ([#8395](rectorphp/rector#…
7e4c352 
…8395)) that was resolved in `^0.19.0`, resolves ([craftcms#18](craftcms#18))
@khalwat khalwat mentioned this issue Jan 28, 2024
Merged
@khalwat
Copy link
Contributor

khalwat commented Jan 28, 2024

Resolved via PR (#19)

TomasVotruba added a commit that referenced this issue Jan 28, 2024
@TomasVotruba
Merge pull request #19 from khalwat/main
c30c331 
fix: Fix upstream issue in `rector/rector` ([#8395](rectorphp/rector#8395)) that was resolved in `^0.19.0`, resolves ([#18](#18))
@datamweb datamweb mentioned this issue Feb 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khalwat @jonw-cogapp