Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings Controller + Model Patches #40

Merged
merged 9 commits into from
Nov 11, 2022
Merged

Settings Controller + Model Patches #40

merged 9 commits into from
Nov 11, 2022

Conversation

AugustMiller
Copy link
Contributor

Description

This supersedes #39, as we had some other related changes that made sense to bundle. Thanks to @vnali for the original report and patch! 😻

Related issues

@AugustMiller AugustMiller mentioned this pull request Nov 10, 2022
Closed
@lukeholder lukeholder self-requested a review November 10, 2022 17:27
lukeholder
lukeholder approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@lukeholder lukeholder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I standardized the changelog entry - but everything else is good. Thanks.

@lukeholder lukeholder merged commit d6b89e3 into develop Nov 11, 2022
@lukeholder lukeholder deleted the bugfix/settings-controller branch November 11, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeholder lukeholder lukeholder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AugustMiller @lukeholder