Out of date with the newest client #43
Comments
|
Yup... this addon isn't updated to the Classic API. I'll get to it, but not before launch. It will most likely depend on how much I feel like I want it when I start leveling for real :) |
|
ok cool. just wanted to let you know. What exactly does that mean though? |
|
This version of addon was designed for the "original" Vanilla WoW 1.12.1 and not 1.13... aka Classic WoW. Therefore the code is out-of-date and does not work. |
|
so its unusable for 1.13? |
|
Correct
…On Fri, Aug 23, 2019 at 1:02 Marc Haubenstock ***@***.***> wrote:
so its unusable for 1.13?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#43?email_source=notifications&email_token=AABB5AARS5LULJGXFWJMSTLQF22ADA5CNFSM4IOMKBJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD45SECI#issuecomment-523969033>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABB5ADD6KB7HO33FAUTQ33QF22ADANCNFSM4IOMKBJA>
.
|
|
You could probably use the original Tour Guide, since it was made for TBC i.e. much newer API. It just lacks some calculations since they added 10% XP buff for TBC. I might test that out when login queues get lower. |
|
Hi, now that the games has dropped, I was wondering if there are any thoughts. None of the AddOns out there available for 1.13 really solve the problem of guide creation very well. I remember using TourGuide on a private server and liking it. Finding out it's not compatible with classic was a shock! I have been wanting to create a guide AddOn and website for a while - not only for leveling, but for a whole bunch of different things. Basically users could create guides for just about everything (leveling, gathering routes, professions, gold grinding, literally whatever) in a fairly accessible way, then everything would be shared through a website. The quest guides are the most interesting part though, and Tour Guide does it extremely well. If it got back up and running, my project would be put aside for a long time because I don't really need to do it... the extras are just an excuse to get the quest guides working. Anyway, I'm going to try to fix up the errors and make the AddOn actually useable for myself. I won't share it unless I get cralor's blessing, but I also just wanted to throw forward that I'd be willing to help update TourGuide to 1.13 if you're interested Cralor. |
|
TekNoLogic's TourGuide seems to be a good starting point. I tested it on Classic and it does not raise any major errors (even shows up the greeting message), but it does not show up normally when running the game. I did not do full diagnostics on why this is since I don't have my typical bug grabbers enabled, but it might be because of the quest data and game data do not match. If this is the case, it should not be a major issue. There might be some APIs that have been disabled since addon was last updated (Cataclysm), which probably need remapping. |
|
That seems like a positively amazing starting point. I'm going to start doing some poking around with it and see what's what (starting in a couple hours). For the time being what I'm doing is just so my friends and I can do some powerleveling and play at least some of the endgame. We aren't the teenagers we were once! TekNoLogic hasn't been active for like a decade or something, so I can't imagine him being mad about me fixing bugs and version incompatibilities, However, I will still message him just in case and as I said before, eventually I going be creating my own AddOn, and I'd just redo everything at that point. |
|
His Github feed seems to indicate that he has some activity even with WoW. I doubt he would be mad if you create a fork and submit a pull request. I also tried to check if the Burning Crusade version works, but I think it has more problems than the Cata version. Probably the best match would be to integrate TBC guides as a starting point and use Cata version otherwise. |
|
Yeah, I'm honestly going to fore-go leveling to get this guy up and running :) I've looked at some classic updated addons and still prefer TourGuide :-) Let me also pull up the Cata version and start poking around! |
|
Starting it as a new project here: https://github.com/cralor/TourGuideClassic |
|
Made an initial quick and dirty fix to make TourGuide UI atleast visible: Edit: and with very little effort it seems to work surprisingly well. |
|
Cool I’ll take a look
Did you see my new repo for it?
…On Fri, Sep 6, 2019 at 10:31 Joakim ***@***.***> wrote:
Made an initial quick and dirty fix to make TourGuide UI atleast visible:
https://github.com/Sefriol/TourGuide/tree/classic
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#43?email_source=notifications&email_token=AABB5AE3CRZDEDI6HHG43BDQIGXIZA5CNFSM4IOMKBJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6BN5LQ#issuecomment-528670382>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABB5AAZZ6KYAYMXWTBOQWDQIGXIZANCNFSM4IOMKBJA>
.
|
|
I just took a look at your edits. Looks good. I made most of the same ones. I'll compare more closely to see if you introduced any improvements. I got it to a good state. The only issue I was having was it was automatically marking Quest Accept tasks as complete without actually having picked them up. |
|
I would just base the repo on the TekNoLogic's repo so we can have the commit history and can easily merge it on top of it incase he wants to continue development. i.e. now it's really hard to see the changes you have done. EDIT: Also fixed TomTom coordinates and changed Party change event to the new one. |
|
Good idea
…On Fri, Sep 6, 2019 at 19:58 Joakim ***@***.***> wrote:
I would just base the repo on the TekNoLogic's repo so we can have the
commit history and can easily merge it on top of it incase he wants to
continue development.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#43?email_source=notifications&email_token=AABB5AE6LVES7IR4GU7DAULQIIZV3A5CNFSM4IOMKBJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6CQCCQ#issuecomment-528810250>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABB5AFO3IWC3UJ7HE3J3K3QIIZV3ANCNFSM4IOMKBJA>
.
|
Pretty much ended in the same spot. For the majority of the tasks it marks them automatically completed. Did not manage to debug the reason for now, but there are couple of things I noticed:
This would lead to me believe that there is some event loop that marks this event complete all the time. |
|
Yup. Can you help me look into getting his debugging setup running?
It has a dependency for his tekDebug addon but it has its own issues. That
would help us haha.
…On Fri, Sep 6, 2019 at 22:54 Joakim ***@***.***> wrote:
I got it to a good state. The only issue I was having was it was
automatically marking Quest Accept tasks as complete without actually
having picked them up.
Pretty much ended in the same spot. For the majority of the tasks it marks
them automatically completed. Did not manage to debug the reason for now,
but there are couple of things I noticed:
1. If you can untag the quest, it will also untag the quest pickup
2. For some quest you cannot even untag them even if the objective is
not complete
This would lead to me believe that there is some event loop that marks
this event complete all the time.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#43?email_source=notifications&email_token=AABB5AEP4BZ7WHLFBEFWNQTQIJOKJA5CNFSM4IOMKBJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6C5HZQ#issuecomment-528864230>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABB5AB7PCVK62H7TJRRO6TQIJOKJANCNFSM4IOMKBJA>
.
|
|
Debugger seems to work. Just use /td instead of the button within UI. I have very limited time, but I try to see if I can figure this out now. |
|
Okey, I narrowed it down. Quest Objectives for those quests are not found, so they are marked as complete. EDIT: i.e. this needs to be fixed https://github.com/Sefriol/TourGuide/blob/classic/TourGuide.lua#L200 |
|
It was little bit different than I thought, but quite close. Does not fix all guide autocompletes, but does well for the major part. Needs more testing though. https://wow.gamepedia.com/API_GetQuestLogTitle was changed in WoD, which caused the quest isComplete check to be in incorrect position. It should have been 6 where as 7 is now populated by "frequency". |
|
I did notice that questlogtitle issue as well.
Sorry I didn’t setup the Git well, would be better to show you my diff. My
apologies.
Thanks though I’ll take a look!
…On Sun, Sep 8, 2019 at 21:09 Joakim ***@***.***> wrote:
It was little bit different than I thought, but quite close.
***@***.***
<Sefriol/TourGuide@a5b5fd0>
Does not fix all guide autocompletes, but does well for the major part.
Needs more testing though.
https://wow.gamepedia.com/API_GetQuestLogTitle was changed in WoD, which
caused the quest isComplete check to be in incorrect position. It should
have been 6 where as 7 is now populated by "frequency".
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#43?email_source=notifications&email_token=AABB5ACK7QPXMV4QP3OWBX3QITTPPA5CNFSM4IOMKBJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6FONMI#issuecomment-529196721>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABB5AE57O3476B6DZ2TIRLQITTPPANCNFSM4IOMKBJA>
.
|
|
You could forcefully fix the git by using following method:
This should restore the commit history and make it easy to see what changes you did. (You might need to map your local master to origin/master. Not sure since I'm writing this out of memory) You can also play it save by doing this to brand new repository. Then when it plays out correctly, you can delete TouGuideClassic repository and rename the new one into it. |
|
Awesome thanks for that. I went ahead and made those changes. |
tldr:
The text was updated successfully, but these errors were encountered: