Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lot of updates #3

Merged
merged 2 commits into from
Jan 22, 2018
Merged

A lot of updates #3

merged 2 commits into from
Jan 22, 2018

Conversation

cralor
Copy link
Owner

@cralor cralor commented Jan 15, 2017

I made some improvements. You can consider merging some or all of these. I haven't done a lot of leveling with it, so I am not positive it's at a release state.

  • Fixed bug tracking quest multiple times on reload
  • Added profession guides
  • Removed Optionhouse button from game menu (access with /oh)
  • Added support for backported version of TomTom
  • Added support to leverage ShaguDB for questgiver accept/turnin
    waypoints in conjunction with TomTom
  • Added GetItemCount shim for WoW 1.12

TomTom backport: https://forum.elysium-project.org/topic/29180-addon-tomtom/

- Fixed bug tracking quest multiple times on reload
- Added profession guides
- Removed Optionhouse button from game menu (access with /oh)
- Added support for backported version of TomTom
- Added support to leverage ShaguDB for questgiver accept/turnin
waypoints in conjunction with TomTom
- Added GetItemCount shim for WoW 1.12
@Road-block
Copy link
Collaborator

That sounds great. I'll take a look if rot doesn't.
Tbh if he doesn't want to spend time on it I'd suggest he gives you permission to push to upstream.

@cralor
Copy link
Owner Author

cralor commented Jan 16, 2017 via email

@Road-block Road-block merged commit 5edc368 into cralor:master Jan 22, 2018
@cralor
Copy link
Owner Author

cralor commented Jan 23, 2018

Thanks Road-block. Do you have any existing interest with this project? It would be great to have a second set of eyes and assistance.

I hadn't added any comments to this latest push (and sorry it was a year apart haha!), but I made some progress on additional backporting, with a heavy focus on getting LightHeaded backported and integrating correctly. I haven't been questing too much as I want to get the addon more complete before doing so, but in my limited testing the coords from LightHeaded seem to be slightly off. This might push me to add an integration with pfQuest in the near future as well, given its database being lined up with Light's Hope. I'm also not too interested in getting LightHeaded's UI up and running, and instead am considering the thought of throwing LightHeaded's DB into TourGuide as a sort of "default database" if pfQuest is not present.

Essentially, would be cool to discuss the vision of the project and where to move forward. There's still some work to do on removing the rest of the OptionHouse dependency, and perhaps a bug or two remaining with detection of the quest completion/accepting/progress with TourGuide's automation. And then the guides will certainly require tweaking given that the current state is with the second expansion slightly in mind.

Oh, and it would be cool to put together an official TomTom backport that coincides... :) I've got one that's pretty decent, but don't really care for the Questie integrations that it came included with. I'd rather see other addons simply hook up with TomTom's API accordingly.

Cheers!

@Road-block
Copy link
Collaborator

To be completely honest, while I'm always tickled by backports of popular addons from later expansions, I'm not as a player very interested in quest helpers so my motivation is low (and I'm involved in a bunch of other addon projects unfortunately)
It would be ideal if you had control of the main-line and I was just a contributor (I'm certainly more interested in a proper plug-able world arrow that multiple addons can use for their needs)

In short if you - provided you have the interest - were main author and I was the assist, it would make much more sense.
I can probably bug @rsheep on discord to transfer the project to you if you want that.

Best regards 😄

@Road-block
Copy link
Collaborator

@cralor Hey rsheep/rot tried to transfer the mainline but you already have a fork.
If you want to get ownership you need to remove your fork 😉

@rsheep
Copy link
Collaborator

rsheep commented Jan 23, 2018

It might be a good idea to change the name to something like VanillaTourGuide or TourGuideVanilla (or whatever you like the most). This way you wouldn't need to change your fork-repo name.

When we are decided I can transfer it within zero-time (almost).

@cralor
Copy link
Owner Author

cralor commented Jan 23, 2018 via email

@rsheep
Copy link
Collaborator

rsheep commented Jan 23, 2018

looks like you got to delete your fork, even after the name change of this repo :(
cralor already has a repository in the rsheep/TourGuideVanilla network

@cralor
Copy link
Owner Author

cralor commented Jan 24, 2018

Done.

zaicopx pushed a commit to zaicopx/TourGuideVanilla that referenced this pull request Feb 22, 2023
The exp/time ratio for the quests in the Ban'ethil Barrow Den area are not good enough to be worth pursuing as part of a speedrun. This commit will also remove elite quests that are time-consuming to solo, or are a bottle-neck on new server launch day (e.g., Mist).
laytya pushed a commit to laytya/TourGuideVanilla that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants