[BUG] defaultBits() returned incorrect result for PANASONIC_AC (#…

…1314)

* Use the correct value.
* Add unit tests to make sure it doesn't happen again for Panasonic.
* Kudos to @taxx for finding the mistake.

For #1307

src/IRsend.cpp

@@ -726,7 +726,7 @@ uint16_t IRsend::defaultBits(const decode_type_t protocol) {
     case NEOCLIMA:
       return kNeoclimaBits;
     case PANASONIC_AC:
-      return kNeoclimaBits;
+      return kPanasonicAcBits;
     case SAMSUNG_AC:
       return kSamsungAcBits;
     case SANYO_AC:

test/ir_Panasonic_test.cpp

@@ -6,6 +6,7 @@
 #include "IRrecv_test.h"
 #include "IRsend.h"
 #include "IRsend_test.h"
+#include "IRtext.h"
 #include "IRutils.h"
 #include "gtest/gtest.h"
 
@@ -1250,3 +1251,21 @@ TEST(TestDecodePanasonicAC, DkeIonRealMessages) {
       "Ion: On, Clock: 00:00, On Timer: 00:00, Off Timer: 00:00",
       ac.toString());
 }
+
+// General housekeeping
+TEST(TestPanasonic, Housekeeping) {
+  // Simple Panasonic protocol. e.g. TVs etc.
+  ASSERT_EQ(D_STR_PANASONIC, typeToString(decode_type_t::PANASONIC));
+  ASSERT_FALSE(hasACState(decode_type_t::PANASONIC));
+  ASSERT_EQ(decode_type_t::PANASONIC, strToDecodeType(D_STR_PANASONIC));
+  ASSERT_FALSE(IRac::isProtocolSupported(decode_type_t::PANASONIC));
+  ASSERT_EQ(kPanasonicBits, IRsend::defaultBits(decode_type_t::PANASONIC));
+  ASSERT_EQ(kNoRepeat, IRsend::minRepeats(decode_type_t::PANASONIC));
+  // Panasonic A/Cs
+  ASSERT_EQ(D_STR_PANASONIC_AC, typeToString(decode_type_t::PANASONIC_AC));
+  ASSERT_TRUE(hasACState(decode_type_t::PANASONIC_AC));
+  ASSERT_EQ(decode_type_t::PANASONIC_AC, strToDecodeType(D_STR_PANASONIC_AC));
+  ASSERT_TRUE(IRac::isProtocolSupported(decode_type_t::PANASONIC_AC));
+  ASSERT_EQ(kPanasonicAcBits, IRsend::defaultBits(decode_type_t::PANASONIC_AC));
+  ASSERT_EQ(kNoRepeat, IRsend::minRepeats(decode_type_t::PANASONIC_AC));
+}