Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing unit test TestCoolixACClass.toCommon #1028

Closed
egueli opened this issue Jan 26, 2020 · 4 comments · Fixed by #1030
Closed

Failing unit test TestCoolixACClass.toCommon #1028

egueli opened this issue Jan 26, 2020 · 4 comments · Fixed by #1030
Assignees

Comments

@egueli
Copy link
Contributor

egueli commented Jan 26, 2020

Version/revision of the library used

27bb582

Expected behavior

  1. make clean run_tests
  2. All unit tests passing

Actual behavior

  1. make clean run_tests
  2. Some unit tests failing:
[ RUN      ] TestCoolixACClass.toCommon
ir_Coolix_test.cpp:634: Failure
Value of: ac.toCommon().turbo
  Actual: true
Expected: false
[  FAILED  ] TestCoolixACClass.toCommon (0 ms)
[ RUN      ] TestCoolixACClass.Issue722
[       OK ] TestCoolixACClass.Issue722 (0 ms)
[ RUN      ] TestCoolixACClass.Issue985
[       OK ] TestCoolixACClass.Issue985 (1 ms)
[----------] 14 tests from TestCoolixACClass (2 ms total)

[----------] Global test environment tear-down
[==========] 22 tests from 3 test cases ran. (5 ms total)
[  PASSED  ] 21 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] TestCoolixACClass.toCommon

Has this library/code previously worked as expected for you?

Not sure; before this commit I was unable to build tests on my machine.

Other useful information

Using clang compiler on Mac:

$ c++ --version
Apple clang version 11.0.0 (clang-1100.0.33.17)
Target: x86_64-apple-darwin19.2.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
crankyoldgit added a commit that referenced this issue Jan 26, 2020
- Possible difference in behaviour between g++ & Apple's c++ memory 
initialisation.

FYI @egueli
Fixes #1028
@crankyoldgit crankyoldgit self-assigned this Jan 26, 2020
@crankyoldgit
Copy link
Owner

Hey @egueli Thanks for the report.

It certainly wasn't/isn't producing that error under g++. :-/

Again, as I can't test the fix myself, can you please download & try PR #1030 / branch https://github.com/crankyoldgit/IRremoteESP8266/tree/Issue1028 and let me know if that quashes it?

@egueli
Copy link
Contributor Author

egueli commented Jan 27, 2020

Thank you for the quick fix @crankyoldgit , Issue1028 makes all tests pass on Clang.

@crankyoldgit
Copy link
Owner

Thanks for the confirmation!

crankyoldgit added a commit that referenced this issue Jan 27, 2020
- Possible difference in behaviour between g++ & Apple's c++ memory 
initialisation.

FYI @egueli
Fixes #1028
crankyoldgit added a commit that referenced this issue Jan 30, 2020
_v2.7.3 (20200130)_

**[Features]**
- Allow protocols to be enabled or disabled with compiler flags. (#1013, #1012)
- Panasonic AC: Add Ion Filter support for DKE models. (#1025, #1024)
- Add support for sending Sony at 38Khz (#1029, #1018, #1019)
- auto_analyse_raw_data.py: Handle analysing messages with no headers. (#1017)

**[Misc]**
- Fix Coolix unit test errors when using Apple c++ compiler. (#1030, #1028)
- Fix Apple clang c++ compiler error in unit tests. (#1027, #1026)
- Improve/fix scraping of supported devices (#1022)
- Panasonic PKR series A/C uses DKE protocol. (#1020, #1021)
- Update NEC supported devices. (#1018)
- Add note to avoid GPIO16 on the ESP8266 for receiving. (#1016, #1015)
crankyoldgit added a commit that referenced this issue Jan 30, 2020
_v2.7.3 (20200130)_

**[Features]**
- Allow protocols to be enabled or disabled with compiler flags. (#1013, #1012)
- Panasonic AC: Add Ion Filter support for DKE models. (#1025, #1024)
- Add support for sending Sony at 38Khz (#1029, #1018, #1019)
- auto_analyse_raw_data.py: Handle analysing messages with no headers. (#1017)

**[Misc]**
- Fix Coolix unit test errors when using Apple c++ compiler. (#1030, #1028)
- Fix Apple clang c++ compiler error in unit tests. (#1027, #1026)
- Improve/fix scraping of supported devices (#1022)
- Panasonic PKR series A/C uses DKE protocol. (#1020, #1021)
- Update NEC supported devices. (#1018)
- Add note to avoid GPIO16 on the ESP8266 for receiving. (#1016, #1015)
@crankyoldgit
Copy link
Owner

The code changes referenced above have been included in the v2.7.3 release of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants