-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing unit test TestCoolixACClass.toCommon #1028
Comments
Hey @egueli Thanks for the report. It certainly wasn't/isn't producing that error under Again, as I can't test the fix myself, can you please download & try PR #1030 / branch https://github.com/crankyoldgit/IRremoteESP8266/tree/Issue1028 and let me know if that quashes it? |
Thank you for the quick fix @crankyoldgit , Issue1028 makes all tests pass on Clang. |
Thanks for the confirmation! |
_v2.7.3 (20200130)_ **[Features]** - Allow protocols to be enabled or disabled with compiler flags. (#1013, #1012) - Panasonic AC: Add Ion Filter support for DKE models. (#1025, #1024) - Add support for sending Sony at 38Khz (#1029, #1018, #1019) - auto_analyse_raw_data.py: Handle analysing messages with no headers. (#1017) **[Misc]** - Fix Coolix unit test errors when using Apple c++ compiler. (#1030, #1028) - Fix Apple clang c++ compiler error in unit tests. (#1027, #1026) - Improve/fix scraping of supported devices (#1022) - Panasonic PKR series A/C uses DKE protocol. (#1020, #1021) - Update NEC supported devices. (#1018) - Add note to avoid GPIO16 on the ESP8266 for receiving. (#1016, #1015)
_v2.7.3 (20200130)_ **[Features]** - Allow protocols to be enabled or disabled with compiler flags. (#1013, #1012) - Panasonic AC: Add Ion Filter support for DKE models. (#1025, #1024) - Add support for sending Sony at 38Khz (#1029, #1018, #1019) - auto_analyse_raw_data.py: Handle analysing messages with no headers. (#1017) **[Misc]** - Fix Coolix unit test errors when using Apple c++ compiler. (#1030, #1028) - Fix Apple clang c++ compiler error in unit tests. (#1027, #1026) - Improve/fix scraping of supported devices (#1022) - Panasonic PKR series A/C uses DKE protocol. (#1020, #1021) - Update NEC supported devices. (#1018) - Add note to avoid GPIO16 on the ESP8266 for receiving. (#1016, #1015)
The code changes referenced above have been included in the v2.7.3 release of the library. |
Version/revision of the library used
27bb582
Expected behavior
make clean run_tests
Actual behavior
make clean run_tests
Has this library/code previously worked as expected for you?
Not sure; before this commit I was unable to build tests on my machine.
Other useful information
Using clang compiler on Mac:
The text was updated successfully, but these errors were encountered: